langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25281] [Chore/Refactor] Improve type annotations in models module #30992

New Issue
Closed
opened 2026-02-21 20:48:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:37 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25281

State: closed
Merged: Yes

Summary

  • Enhanced type annotations throughout the models module
  • Fixed mypy and pyright type checking errors
  • Improved code maintainability and type safety

Fixes #25280

Changes Made

  • Added proper type hints to methods and properties in models/account.py, models/dataset.py, models/model.py, models/workflow.py, and models/types.py
  • Fixed type incompatibilities and removed unnecessary type ignores
  • Enhanced type safety for JSON fields and dictionary operations
  • Improved type annotations for Flask-Login integration
  • Fixed enum typing issues with proper string type annotations
**Original Pull Request:** https://github.com/langgenius/dify/pull/25281 **State:** closed **Merged:** Yes --- ## Summary - Enhanced type annotations throughout the models module - Fixed mypy and pyright type checking errors - Improved code maintainability and type safety Fixes #25280 ## Changes Made - Added proper type hints to methods and properties in models/account.py, models/dataset.py, models/model.py, models/workflow.py, and models/types.py - Fixed type incompatibilities and removed unnecessary type ignores - Enhanced type safety for JSON fields and dictionary operations - Improved type annotations for Flask-Login integration - Fixed enum typing issues with proper string type annotations
yindo added the pull-request label 2026-02-21 20:48:37 -05:00
yindo closed this issue 2026-02-21 20:48:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#30992
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?