langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25328] fix: add stable sorting for trigger list to prevent position changes #31015

New Issue
Closed
opened 2026-02-21 20:48:40 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:40 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25328

State: closed
Merged: Yes

Summary

Fixed trigger list position instability when toggling trigger status.

Problem:
When multiple triggers were created at nearly the same time, they could have identical created_at timestamps. When sorting by created_at DESC only, the database used unstable secondary sorting. Updating a trigger status would change its updated_at field, potentially affecting the unstable sort order and causing triggers to change positions.

Solution:
Added id as a secondary sort key for stable sorting.

  • Uses existing primary key index (zero performance overhead)
  • Provides completely stable sorting since id is unique and immutable
  • Maintains original business logic (newest triggers first)
  • No database migration required

Testing:

  • Triggers now maintain consistent positions when toggling status
  • No breaking changes to existing functionality

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/25328 **State:** closed **Merged:** Yes --- ## Summary Fixed trigger list position instability when toggling trigger status. **Problem**: When multiple triggers were created at nearly the same time, they could have identical created_at timestamps. When sorting by created_at DESC only, the database used unstable secondary sorting. Updating a trigger status would change its updated_at field, potentially affecting the unstable sort order and causing triggers to change positions. **Solution**: Added id as a secondary sort key for stable sorting. - Uses existing primary key index (zero performance overhead) - Provides completely stable sorting since id is unique and immutable - Maintains original business logic (newest triggers first) - No database migration required **Testing**: - Triggers now maintain consistent positions when toggling status - No breaking changes to existing functionality ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:48:40 -05:00
yindo closed this issue 2026-02-21 20:48:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31015
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?