langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #25425] Fix: Use --fix flag instead of --fix-only in autofix workflow #31058

New Issue
Closed
opened 2026-02-21 20:48:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:48:45 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/25425

State: closed
Merged: Yes

Summary

This PR fixes the autofix workflow to use ruff check --fix instead of ruff check --fix-only. The --fix-only flag was silently ignoring ruff errors that cannot be auto-fixed, which could allow problematic code to pass through the workflow without notification.

Changes

  • Updated .github/workflows/autofix.yml to use --fix flag for ruff check

Why this change is needed

The previous configuration with --fix-only would only apply safe fixes and ignore any errors that couldn't be automatically fixed. This meant that code quality issues requiring manual intervention would go unnoticed. Using --fix ensures all errors are reported, even those that need manual fixes.

Fixes #25424

**Original Pull Request:** https://github.com/langgenius/dify/pull/25425 **State:** closed **Merged:** Yes --- ## Summary This PR fixes the autofix workflow to use `ruff check --fix` instead of `ruff check --fix-only`. The `--fix-only` flag was silently ignoring ruff errors that cannot be auto-fixed, which could allow problematic code to pass through the workflow without notification. ## Changes - Updated `.github/workflows/autofix.yml` to use `--fix` flag for ruff check ## Why this change is needed The previous configuration with `--fix-only` would only apply safe fixes and ignore any errors that couldn't be automatically fixed. This meant that code quality issues requiring manual intervention would go unnoticed. Using `--fix` ensures all errors are reported, even those that need manual fixes. Fixes #25424
yindo added the pull-request label 2026-02-21 20:48:45 -05:00
yindo closed this issue 2026-02-21 20:48:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31058
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?