langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #26259] refactor(web): simplify lint scripts, remove duplicates and standardize naming #31373

New Issue
Closed
opened 2026-02-21 20:49:20 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:49:20 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/26259

State: closed
Merged: Yes

Summary

This PR simplifies the web/package.json lint scripts by removing duplicates and standardizing naming conventions.

Changes made:

  • ✅ Remove duplicate eslint script (identical to lint)
  • ✅ Remove redundant scripts: fix, eslint-fix, lint-only-show-error, eslint-fix-only-show-error
  • ✅ Standardize to 4 core lint scripts with consistent lint:* naming:
    • lint: basic linting
    • lint:fix: auto-fix issues
    • lint:quiet: show errors only
    • lint:complexity: complexity analysis
  • ✅ All scripts now use consistent caching and concurrency configuration

Benefits:

  • Reduced maintenance overhead (7 scripts → 4 scripts)
  • Clear naming convention following npm best practices
  • Consistent configuration across all lint scripts
  • Improved developer experience with intuitive script names

Fixes #26257

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/26259 **State:** closed **Merged:** Yes --- ## Summary This PR simplifies the web/package.json lint scripts by removing duplicates and standardizing naming conventions. **Changes made:** - ✅ Remove duplicate `eslint` script (identical to `lint`) - ✅ Remove redundant scripts: `fix`, `eslint-fix`, `lint-only-show-error`, `eslint-fix-only-show-error` - ✅ Standardize to 4 core lint scripts with consistent `lint:*` naming: - `lint`: basic linting - `lint:fix`: auto-fix issues - `lint:quiet`: show errors only - `lint:complexity`: complexity analysis - ✅ All scripts now use consistent caching and concurrency configuration **Benefits:** - Reduced maintenance overhead (7 scripts → 4 scripts) - Clear naming convention following npm best practices - Consistent configuration across all lint scripts - Improved developer experience with intuitive script names Fixes #26257 ## Checklist - [x] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:49:20 -05:00
yindo closed this issue 2026-02-21 20:49:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31373
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?