langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #26675] fix(workflow): Remove frontend upper limit on HTTP node timeout values #31513

New Issue
Closed
opened 2026-02-21 20:49:36 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:49:36 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/26675

State: closed
Merged: No

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #26319

Remove frontend upper limit restriction on HTTP node timeout values to allow users to configure longer timeouts as needed for slow external services.

Problem

Users reported that the HTTP node times out after 10 minutes even when they need longer timeouts for slow-processing services (like document processing, knowledge base operations, etc.).

The issue was that the frontend enforced a hard limit on timeout values:

  • Connect timeout: capped at 300s (5 minutes)
  • Read/Write timeout: capped at 600s (10 minutes)

Even though backend supports configuring higher limits via .env variables:

HTTP_REQUEST_MAX_CONNECT_TIMEOUT=<custom_value>
HTTP_REQUEST_MAX_READ_TIMEOUT=<custom_value>
HTTP_REQUEST_MAX_WRITE_TIMEOUT=<custom_value>

The frontend validation prevented users from entering values higher than the default caps, making these environment variables ineffective.

Solution

Changed the validation logic in the timeout input field from:

const value = Math.max(min, Math.min(max, parsedValue))

to:

const value = Math.max(min, parsedValue)

Now the frontend:

  • ✅ Enforces minimum value (1 second) to prevent invalid inputs
  • ✅ Allows users to configure timeout values beyond default suggestions
  • ✅ Respects backend .env configuration as the final authority on max limits
  • ✅ Properly separates concerns: frontend for UX validation, backend for security boundaries

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/26675 **State:** closed **Merged:** No --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary Fixes #26319 Remove frontend upper limit restriction on HTTP node timeout values to allow users to configure longer timeouts as needed for slow external services. ## Problem Users reported that the HTTP node times out after 10 minutes even when they need longer timeouts for slow-processing services (like document processing, knowledge base operations, etc.). The issue was that the frontend enforced a hard limit on timeout values: - Connect timeout: capped at 300s (5 minutes) - Read/Write timeout: capped at 600s (10 minutes) Even though backend supports configuring higher limits via `.env` variables: ```bash HTTP_REQUEST_MAX_CONNECT_TIMEOUT=<custom_value> HTTP_REQUEST_MAX_READ_TIMEOUT=<custom_value> HTTP_REQUEST_MAX_WRITE_TIMEOUT=<custom_value> ``` The frontend validation prevented users from entering values higher than the default caps, making these environment variables ineffective. ## Solution Changed the validation logic in the timeout input field from: ```typescript const value = Math.max(min, Math.min(max, parsedValue)) ``` to: ```typescript const value = Math.max(min, parsedValue) ``` **Now the frontend:** - ✅ Enforces minimum value (1 second) to prevent invalid inputs - ✅ Allows users to configure timeout values beyond default suggestions - ✅ Respects backend `.env` configuration as the final authority on max limits - ✅ Properly separates concerns: frontend for UX validation, backend for security boundaries ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:49:36 -05:00
yindo closed this issue 2026-02-21 20:49:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31513
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?