langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #26733] fix: #26668 restore manual tool parameter values #31534

New Issue
Closed
opened 2026-02-21 20:49:39 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:49:39 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/26733

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fixes #26668

Fix regression where manually configured Agent tool parameter values were being dropped and re-filled by the LLM after upgrading from 1.8.x to 1.9.x.

Background / Root Cause：

In 1.8.x the enum for auto/manual parameter mode used explicit integer values:

* CLOSE = 0 (manual)
* OPEN = 1 (auto)

In 1.9.x it was changed to an IntEnum with auto(), shifting values to:

* CLOSE = 1
* OPEN = 2

which makes the condition if param.get("auto", ParamsAutoGenerated.OPEN.value) == ParamsAutoGenerated.CLOSE.value invalid.

Screenshots

After this change is applied, the manually-filled parameters are handled as expected (those parameters were null as posted in the issue description).
04f321fd-ee60-46f2-b4c9-f9ec727c6871

Checklist

  • This change requires a documentation update, included: Dify Document

  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)

  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.

  • I've updated the documentation accordingly.

  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

**Original Pull Request:** https://github.com/langgenius/dify/pull/26733 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 2. Ensure there is an associated issue and you have been assigned to it > 3. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Fixes #26668 Fix regression where manually configured Agent tool parameter values were being dropped and re-filled by the LLM after upgrading from 1.8.x to 1.9.x. Background / Root Cause： In 1.8.x the enum for auto/manual parameter mode used explicit integer values: ``` * CLOSE = 0 (manual) * OPEN = 1 (auto) ``` In 1.9.x it was changed to an IntEnum with `auto()`, shifting values to: ``` * CLOSE = 1 * OPEN = 2 ``` which makes the condition ``if param.get("auto", ParamsAutoGenerated.OPEN.value) == ParamsAutoGenerated.CLOSE.value`` invalid. ## Screenshots After this change is applied, the manually-filled parameters are handled as expected (those parameters were null as posted in the issue description). ![04f321fd-ee60-46f2-b4c9-f9ec727c6871](https://github.com/user-attachments/assets/03823068-2b97-4bf6-a9bb-d52acbe4c338) ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:49:39 -05:00
yindo closed this issue 2026-02-21 20:49:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31534
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?