langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 20:45:26 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #27712] refactor(api): set default value for EasyUIBasedAppGenerateEntity.query #31837

New Issue
Closed
opened 2026-02-21 20:50:14 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:14 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/27712

State: closed
Merged: Yes

Summary

This PR improves type safety for the query field in EasyUIBasedAppGenerateEntity by changing its type hint from str | None = None to str = "".

After reviewing all usages of EasyUIBasedAppGenerateEntity.query throughout the codebase, the field is always treated as a string and never explicitly checked for None. This change:

  1. Improves type safety by eliminating unnecessary optional typing
  2. Enhances code clarity by accurately representing actual usage patterns
  3. Reduces complexity by removing the need for None checks
  4. Provides better developer experience with improved IDE autocomplete and type checking

Changes:

  • Changed EasyUIBasedAppGenerateEntity.query from str | None = None to str = ""
  • Location: api/core/app/entities/app_invoke_entities.py:132

Fixes #27711

Screenshots

Before After
query: str | None = None query: str = ""

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/27712 **State:** closed **Merged:** Yes --- ## Summary This PR improves type safety for the `query` field in `EasyUIBasedAppGenerateEntity` by changing its type hint from `str | None = None` to `str = ""`. After reviewing all usages of `EasyUIBasedAppGenerateEntity.query` throughout the codebase, the field is always treated as a string and never explicitly checked for `None`. This change: 1. **Improves type safety** by eliminating unnecessary optional typing 2. **Enhances code clarity** by accurately representing actual usage patterns 3. **Reduces complexity** by removing the need for None checks 4. **Provides better developer experience** with improved IDE autocomplete and type checking **Changes:** - Changed `EasyUIBasedAppGenerateEntity.query` from `str | None = None` to `str = ""` - Location: `api/core/app/entities/app_invoke_entities.py:132` Fixes #27711 ## Screenshots | Before | After | |--------|-------| | `query: str \| None = None` | `query: str = ""` | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos\!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:50:14 -05:00
yindo closed this issue 2026-02-21 20:50:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31837
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?