langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #27850] test: create new test scripts and update some existing test scripts o… #31873

New Issue
Closed
opened 2026-02-21 20:50:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/27850

State: closed
Merged: Yes

Description

This PR adds comprehensive test coverage for 9 frontend utility modules, creating comprehensive tests.

Fixes

Closes #26000
Closes #25974
Closes #25962

Test Files Added

  1. navigation.spec.ts - URL and query parameter manipulation
  2. completion-params.spec.ts - Model parameter validation and merging
  3. classnames.spec.ts - CSS class manipulation with Tailwind merge
  4. app-redirection.spec.ts - Permission-based routing logic
  5. time.spec.ts - Date comparison and formatting
  6. permission.spec.ts - Dataset edit permission logic
  7. mcp.spec.ts - Model Context Protocol icon detection
  8. tool-call.spec.ts - AI model function call support detection
  9. get-icon.spec.ts - Marketplace plugin icon URL generation

All tests follow best practices with proper mocking, edge case coverage, and clear documentation.

Screenshots

Before After
Not enough test coverage for core utility modules Comprehensive test coverage across 9 utility modules (navigation, completion-params, classnames, app-redirection, time, permission, mcp, tool-call, get-icon)

Checklist

  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

Contribution by Gittensor, learn more at https://gittensor.io/

**Original Pull Request:** https://github.com/langgenius/dify/pull/27850 **State:** closed **Merged:** Yes --- ## Description This PR adds comprehensive test coverage for 9 frontend utility modules, creating comprehensive tests. ### Fixes Closes #26000 Closes #25974 Closes #25962 ### Test Files Added 1. **`navigation.spec.ts`** - URL and query parameter manipulation 2. **`completion-params.spec.ts`** - Model parameter validation and merging 3. **`classnames.spec.ts`** - CSS class manipulation with Tailwind merge 4. **`app-redirection.spec.ts`** - Permission-based routing logic 5. **`time.spec.ts`** - Date comparison and formatting 6. **`permission.spec.ts`** - Dataset edit permission logic 7. **`mcp.spec.ts`** - Model Context Protocol icon detection 8. **`tool-call.spec.ts`** - AI model function call support detection 9. **`get-icon.spec.ts`** - Marketplace plugin icon URL generation All tests follow best practices with proper mocking, edge case coverage, and clear documentation. ## Screenshots | Before | After | |--------|-------| | Not enough test coverage for core utility modules | Comprehensive test coverage across 9 utility modules (navigation, completion-params, classnames, app-redirection, time, permission, mcp, tool-call, get-icon) | ## Checklist - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods Contribution by Gittensor, learn more at https://gittensor.io/
yindo added the pull-request label 2026-02-21 20:50:18 -05:00
yindo closed this issue 2026-02-21 20:50:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31873
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?