langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 20:45:26 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #27849] fix: installation_id is missing when in tools page #31874

New Issue
Closed
opened 2026-02-21 20:50:18 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:18 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/27849

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This pull request refactors the plugin uninstallation logic in the DetailHeader component to use the id property instead of installation_id. This change ensures consistency in how plugins are identified and simplifies the code by updating all relevant references. Additionally, a commented-out line related to usage information display has been removed for cleaner code.

Refactor plugin identification:

  • Replaced usage of installation_id with id throughout the DetailHeader component, including in function parameters and dependency arrays. [1] [2] [3]

Code cleanup:

  • Removed a commented-out line that referenced displaying the number of apps using the plugin in the delete confirmation dialog.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/27849 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This pull request refactors the plugin uninstallation logic in the `DetailHeader` component to use the `id` property instead of `installation_id`. This change ensures consistency in how plugins are identified and simplifies the code by updating all relevant references. Additionally, a commented-out line related to usage information display has been removed for cleaner code. **Refactor plugin identification:** * Replaced usage of `installation_id` with `id` throughout the `DetailHeader` component, including in function parameters and dependency arrays. [[1]](diffhunk://#diff-5c430ddd34d22fd011768194667a128dc0b87019fc0596db568fd7934c8e935dL76-R76) [[2]](diffhunk://#diff-5c430ddd34d22fd011768194667a128dc0b87019fc0596db568fd7934c8e935dL200-R200) [[3]](diffhunk://#diff-5c430ddd34d22fd011768194667a128dc0b87019fc0596db568fd7934c8e935dL210-R210) **Code cleanup:** * Removed a commented-out line that referenced displaying the number of apps using the plugin in the delete confirmation dialog. ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:50:18 -05:00
yindo closed this issue 2026-02-21 20:50:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31874
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?