langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #27867] Fix/template transformer line number #31878

New Issue
Closed
opened 2026-02-21 20:50:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/27867

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR fixes #27831 related to incorrect line numbers in template transformers for Python and Node.js templates. The changes include:

  • Backend fixes: Removed redundant header lines in Python and Node templates to align error line numbers correctly (fix(template-transformer)).
  • Unit tests: Added tests to verify that scripts start counting from user code for Python and JavaScript transformers.
  • Frontend fix: Added whitespace-pre-wrap to status error display to ensure proper line breaks in code error messages.

Motivation & Context:
Previously, error messages in transformed templates could display incorrect line numbers due to extra header lines, and multi-line error messages did not preserve line breaks in the UI. This PR ensures accurate error line numbers and proper display in the frontend.

Dependencies: None

Fixes: Fixes #27831

Screenshots

Before After

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/27867 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This PR fixes #27831 related to incorrect line numbers in template transformers for Python and Node.js templates. The changes include: - **Backend fixes**: Removed redundant header lines in Python and Node templates to align error line numbers correctly (`fix(template-transformer)`). - **Unit tests**: Added tests to verify that scripts start counting from user code for Python and JavaScript transformers. - **Frontend fix**: Added `whitespace-pre-wrap` to status error display to ensure proper line breaks in code error messages. **Motivation & Context:** Previously, error messages in transformed templates could display incorrect line numbers due to extra header lines, and multi-line error messages did not preserve line breaks in the UI. This PR ensures accurate error line numbers and proper display in the frontend. **Dependencies:** None **Fixes:** `Fixes #27831` ## Screenshots | Before | After | |--------|-------| | <img src="https://github.com/user-attachments/assets/3b6f5219-e6c0-46e2-88d2-77f11a7ae1f6" width="300"/> | <img src="https://github.com/user-attachments/assets/28f730cb-7a05-477a-9ce1-6ae5ff4ba370" width="300"/> | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:50:19 -05:00
yindo closed this issue 2026-02-21 20:50:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31878
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?