langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #27871] Fix: Correctly handle merged cells in DOCX tables to prevent content duplication and loss #31881

New Issue
Closed
opened 2026-02-21 20:50:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/27871

State: closed
Merged: Yes

Summary

Fixes #27870

This PR resolves a critical issue in word_extractor.py where tables containing merged cells (especially in leading columns) caused incorrect content extraction: Merged cells in the first few columns led to duplicated content across columns, while subsequent columns' data was entirely lost.

This is caused by incorrect looping logic. I fix it with using the actual column index to get the correct cell.

Screenshots

test_case.docx

image

Before
The parsing result is
'| 1-1 | | 1-1 | | 1-2 |\n| --- | --- | --- | --- | --- |\n| 2-1 | 2-2 | | | |\n\n'

After
The parsing result is
'| 1-1 | | 1-2 | 1-3 | 1-4 |\n| --- | --- | --- | --- | --- |\n| 2-1 | 2-2 | | | |\n\n'

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/27871 **State:** closed **Merged:** Yes --- ## Summary Fixes #27870 This PR resolves a critical issue in `word_extractor.py` where tables containing merged cells (especially in leading columns) caused incorrect content extraction: Merged cells in the first few columns led to duplicated content across columns, while subsequent columns' data was entirely lost. This is caused by incorrect looping logic. I fix it with using the actual column index to get the correct cell. ## Screenshots [test_case.docx](https://github.com/user-attachments/files/23353511/test_case.docx) <img width="1038" height="130" alt="image" src="https://github.com/user-attachments/assets/2be19755-5a90-4089-b0ba-3c84a702bcec" /> **Before** The parsing result is `'| 1-1 | | 1-1 | | 1-2 |\n| --- | --- | --- | --- | --- |\n| 2-1 | 2-2 | | | |\n\n'` **After** The parsing result is `'| 1-1 | | 1-2 | 1-3 | 1-4 |\n| --- | --- | --- | --- | --- |\n| 2-1 | 2-2 | | | |\n\n'` ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:50:19 -05:00
yindo closed this issue 2026-02-21 20:50:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#31881
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?