langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #28653] Feat/add test script for tool models #32122

New Issue
Closed
opened 2026-02-21 20:50:47 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:47 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/28653

State: closed
Merged: Yes

Add Comprehensive Unit Tests for Tool Models

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR adds comprehensive unit tests for tool models in api/tests/unit_tests/models/test_tool_models.py, covering:

  • BuiltinToolProvider - Model validation, credential management, OAuth support, and relationship testing
  • ApiToolProvider - Schema validation, credential storage, authentication types, and tool bundle parsing
  • OAuth Models - System and tenant-level OAuth client models with credential handling
  • ToolLabelBinding - Label binding creation and unique constraint validation
  • Credential Storage - JSON storage patterns, encryption handling, and credential expiration tracking

Fixes

Closes https://github.com/langgenius/dify/issues/28655

Test Coverage (40 tests)

  • ✅ 10 tests for BuiltinToolProvider validation and operations
  • ✅ 11 tests for ApiToolProvider validation and operations
  • ✅ 8 tests for OAuth client models (system and tenant level)
  • ✅ 4 tests for ToolLabelBinding relationships
  • ✅ 7 tests for credential storage patterns

All tests follow TDD best practices with Arrange-Act-Assert structure, include comprehensive docstrings, and cover edge cases (None values, empty strings, defaults).

Screenshots

Not applicable - backend unit tests only.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Contribution by Gittensor, learn more at https://gittensor.io/

**Original Pull Request:** https://github.com/langgenius/dify/pull/28653 **State:** closed **Merged:** Yes --- # Add Comprehensive Unit Tests for Tool Models > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This PR adds comprehensive unit tests for tool models in `api/tests/unit_tests/models/test_tool_models.py`, covering: - **BuiltinToolProvider** - Model validation, credential management, OAuth support, and relationship testing - **ApiToolProvider** - Schema validation, credential storage, authentication types, and tool bundle parsing - **OAuth Models** - System and tenant-level OAuth client models with credential handling - **ToolLabelBinding** - Label binding creation and unique constraint validation - **Credential Storage** - JSON storage patterns, encryption handling, and credential expiration tracking ### Fixes Closes https://github.com/langgenius/dify/issues/28655 ### Test Coverage (40 tests) - ✅ 10 tests for BuiltinToolProvider validation and operations - ✅ 11 tests for ApiToolProvider validation and operations - ✅ 8 tests for OAuth client models (system and tenant level) - ✅ 4 tests for ToolLabelBinding relationships - ✅ 7 tests for credential storage patterns All tests follow TDD best practices with Arrange-Act-Assert structure, include comprehensive docstrings, and cover edge cases (None values, empty strings, defaults). ## Screenshots Not applicable - backend unit tests only. ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods Contribution by Gittensor, learn more at https://gittensor.io/
yindo added the pull-request label 2026-02-21 20:50:47 -05:00
yindo closed this issue 2026-02-21 20:50:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32122
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?