langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #28730] fix: use default_factory for callable defaults in ORM dataclasses #32155

New Issue
Closed
opened 2026-02-21 20:50:51 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:51 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/28730

State: closed
Merged: Yes

Fixes #28729

Summary

This PR fixes SQLAlchemy deprecation warnings by changing default=lambda: ... to default_factory=lambda: ... for id fields with init=False in ORM-mapped dataclasses.

The warnings indicate that passing callable objects to the default parameter in ORM-mapped Dataclasses context is ambiguous and will raise errors in future SQLAlchemy releases. Using default_factory explicitly signals that the callable provides default values for dataclass instances.

Affected models:

  • api/models/account.py: Account, Tenant, TenantAccountJoin, AccountIntegrate
  • api/models/trigger.py: TriggerSubscription, TriggerOAuthSystemClient, TriggerOAuthTenantClient, WorkflowTriggerLog, WorkflowWebhookTrigger, WorkflowPluginTrigger, AppTrigger, WorkflowSchedulePlan
  • api/models/web.py: SavedMessage, PinnedConversation
  • api/models/workflow.py: WorkflowAppLog

Screenshots

N/A - Code refactor only, no UI changes.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/28730 **State:** closed **Merged:** Yes --- Fixes #28729 ## Summary This PR fixes SQLAlchemy deprecation warnings by changing `default=lambda: ...` to `default_factory=lambda: ...` for `id` fields with `init=False` in ORM-mapped dataclasses. The warnings indicate that passing callable objects to the `default` parameter in ORM-mapped Dataclasses context is ambiguous and will raise errors in future SQLAlchemy releases. Using `default_factory` explicitly signals that the callable provides default values for dataclass instances. **Affected models:** - `api/models/account.py`: `Account`, `Tenant`, `TenantAccountJoin`, `AccountIntegrate` - `api/models/trigger.py`: `TriggerSubscription`, `TriggerOAuthSystemClient`, `TriggerOAuthTenantClient`, `WorkflowTriggerLog`, `WorkflowWebhookTrigger`, `WorkflowPluginTrigger`, `AppTrigger`, `WorkflowSchedulePlan` - `api/models/web.py`: `SavedMessage`, `PinnedConversation` - `api/models/workflow.py`: `WorkflowAppLog` ## Screenshots N/A - Code refactor only, no UI changes. ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:50:51 -05:00
yindo closed this issue 2026-02-21 20:50:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32155
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?