langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #28833] feat: complete test script of notion provider #32198

New Issue
Closed
opened 2026-02-21 20:50:56 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:56 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/28833

State: closed
Merged: Yes

Add Comprehensive Unit Tests for Notion Datasource Provider

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR adds comprehensive unit tests for the Notion datasource provider to improve code coverage and ensure reliability of the Notion integration functionality.

Fixes

Closes https://github.com/langgenius/dify/issues/28832

What's Added

New Test File: api/tests/unit_tests/core/datasource/test_notion_provider.py

The test suite covers all critical aspects of the Notion provider:

  • Authentication Handling (4 tests)

    • OAuth token authentication
    • Integration token fallback
    • Credential retrieval from database
    • Missing credential error handling

  • Page Retrieval (7 tests)

    • Simple pages with basic blocks
    • Pages with heading blocks (H1, H2, H3)
    • Pagination handling for large pages
    • Nested block structures
    • Error handling (HTTP errors, invalid responses, network failures)

  • Database Retrieval (6 tests)

    • Simple database queries
    • Database pagination
    • Multiple property types (title, select, multi_select, rich_text)
    • Empty database handling
    • Malformed API responses

  • Block Content Parsing (4 tests)

    • Various block types (code, quote, lists, toggle, callout)
    • Mixed block types in realistic scenarios
    • Empty blocks handling

  • Table Parsing (4 tests)

    • Simple tables with headers and rows
    • Tables with empty cells
    • Table pagination
    • Tables with many columns

  • Advanced Database Properties (3 tests)

    • Multiple property types (date, number, checkbox, URL, email, phone, status)
    • Rich text properties
    • Large database pagination

  • Error Scenarios (10 tests via parametrize)

    • Network errors (timeouts, connection failures)
    • HTTP status errors (401, 403, 404, 429)
    • Malformed API responses

  • Integration Tests (3 tests)

    • Complete page extraction workflow
    • Complete database extraction workflow
    • Invalid page type error handling

  • Provider Controller (3 tests)

    • Controller initialization
    • Datasource retrieval
    • Error handling

Test Statistics

  • Total Tests: 50 tests (all passing ✅)
  • File Size: 1,456 lines
  • Coverage: Comprehensive coverage of all Notion provider functionality
  • Test Pattern: All tests follow Arrange-Act-Assert pattern
  • Mocking: Uses proper mocking to avoid external dependencies

Code Quality

  • ✅ All tests passing
  • ✅ Follows project testing conventions (pytest, fixtures, parametrize)
  • ✅ Comprehensive docstrings and inline comments
  • ✅ Proper type hints
  • ✅ Passed ruff format and ruff check
  • ✅ No external dependencies required for tests

Screenshots

Not applicable - this PR adds unit tests only.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Testing

Run the tests with:

uv run --project api pytest api/tests/unit_tests/core/datasource/test_notion_provider.py -v

All 50 tests pass successfully in ~33 seconds.

Contribution by Gittensor, learn more at https://gittensor.io/

**Original Pull Request:** https://github.com/langgenius/dify/pull/28833 **State:** closed **Merged:** Yes --- # Add Comprehensive Unit Tests for Notion Datasource Provider > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This PR adds comprehensive unit tests for the Notion datasource provider to improve code coverage and ensure reliability of the Notion integration functionality. ### Fixes Closes https://github.com/langgenius/dify/issues/28832 ### What's Added **New Test File**: `api/tests/unit_tests/core/datasource/test_notion_provider.py` The test suite covers all critical aspects of the Notion provider: - **Authentication Handling** (4 tests) - OAuth token authentication - Integration token fallback - Credential retrieval from database - Missing credential error handling - **Page Retrieval** (7 tests) - Simple pages with basic blocks - Pages with heading blocks (H1, H2, H3) - Pagination handling for large pages - Nested block structures - Error handling (HTTP errors, invalid responses, network failures) - **Database Retrieval** (6 tests) - Simple database queries - Database pagination - Multiple property types (title, select, multi_select, rich_text) - Empty database handling - Malformed API responses - **Block Content Parsing** (4 tests) - Various block types (code, quote, lists, toggle, callout) - Mixed block types in realistic scenarios - Empty blocks handling - **Table Parsing** (4 tests) - Simple tables with headers and rows - Tables with empty cells - Table pagination - Tables with many columns - **Advanced Database Properties** (3 tests) - Multiple property types (date, number, checkbox, URL, email, phone, status) - Rich text properties - Large database pagination - **Error Scenarios** (10 tests via parametrize) - Network errors (timeouts, connection failures) - HTTP status errors (401, 403, 404, 429) - Malformed API responses - **Integration Tests** (3 tests) - Complete page extraction workflow - Complete database extraction workflow - Invalid page type error handling - **Provider Controller** (3 tests) - Controller initialization - Datasource retrieval - Error handling ### Test Statistics - **Total Tests**: 50 tests (all passing ✅) - **File Size**: 1,456 lines - **Coverage**: Comprehensive coverage of all Notion provider functionality - **Test Pattern**: All tests follow Arrange-Act-Assert pattern - **Mocking**: Uses proper mocking to avoid external dependencies ### Code Quality - ✅ All tests passing - ✅ Follows project testing conventions (pytest, fixtures, parametrize) - ✅ Comprehensive docstrings and inline comments - ✅ Proper type hints - ✅ Passed `ruff format` and `ruff check` - ✅ No external dependencies required for tests ## Screenshots Not applicable - this PR adds unit tests only. ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods ## Testing Run the tests with: ```bash uv run --project api pytest api/tests/unit_tests/core/datasource/test_notion_provider.py -v ``` All 50 tests pass successfully in ~33 seconds. Contribution by Gittensor, learn more at https://gittensor.io/
yindo added the pull-request label 2026-02-21 20:50:56 -05:00
yindo closed this issue 2026-02-21 20:50:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32198
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?