langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #28849] feat: complete test script of google driver provider #32207

New Issue
Closed
opened 2026-02-21 20:50:57 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:57 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/28849

State: closed
Merged: No

Add Comprehensive Unit Tests for Google Drive Datasource Provider

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

This PR adds comprehensive unit tests for the Google Drive datasource provider, ensuring robust coverage of all core functionality including OAuth authentication, file operations, and incremental sync capabilities.

Fixes

Closes https://github.com/langgenius/dify/issues/28848

What's Changed

  • New Test File: api/tests/unit_tests/core/datasource/test_google_drive_provider.py
  • Total Tests: 45 comprehensive test cases
  • Test Coverage: 100% of Google Drive provider functionality

Test Categories

  1. OAuth Authentication (5 tests)

    • OAuth2 token initialization and management
    • Token refresh on expiry
    • Credential encryption handling
    • Missing credentials scenarios

  2. File Listing (5 tests)

    • Root folder browsing
    • Pagination with page tokens
    • Subfolder/bucket navigation
    • Empty folder handling
    • Various file types and sizes

  3. File Download (5 tests)

    • Single file download
    • Downloads from specific buckets
    • Large file streaming
    • Binary and text file handling

  4. Incremental Sync (5 tests)

    • Modified file detection
    • No-change scenarios
    • Pagination in sync operations
    • Deleted file tracking
    • Full vs incremental sync comparison

  5. Provider Controller (6 tests)

    • Provider initialization
    • Datasource retrieval
    • Credential requirements
    • Error handling for missing datasources

  6. Error Handling (4 tests)

    • Authentication failures
    • Invalid file IDs
    • Rate limiting
    • Network errors

  7. Advanced Scenarios (9 tests)

    • Shared drives (Team Drives)
    • Google Workspace files (Docs, Sheets, Slides)
    • Unicode and special characters in filenames
    • Deep pagination (50+ files)
    • Mixed content types
    • Comprehensive file metadata
    • Multiple change type tracking
    • Concurrent operations

  8. Edge Cases (6 tests)

    • Zero-byte files
    • Extremely long filenames (255+ chars)
    • Files without extensions
    • Duplicate filenames in different folders
    • Deeply nested folder structures
    • Empty file downloads

Key Features

  • ✅ Well-documented: Comprehensive docstrings and inline comments for better code understanding
  • ✅ Follows TDD: Arrange-Act-Assert pattern throughout
  • ✅ No external dependencies: All tests use mocking for fast, reliable execution
  • ✅ Ruff lint compliant: All code quality checks pass
  • ✅ Fast execution: All 45 tests run in ~33 seconds

Testing Results

# All tests pass
$ uv run --project api pytest api/tests/unit_tests/core/datasource/test_google_drive_provider.py -v
45 passed in 33.07s

# Ruff lint passes
$ uv run --project api ruff check api/tests/unit_tests/core/datasource/test_google_drive_provider.py
All checks passed!

Screenshots

Not applicable - this PR adds test coverage only, no UI changes.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Additional Notes

  • All tests follow existing Dify project testing conventions
  • Tests are isolated and don't require external Google Drive API access
  • Comprehensive coverage ensures reliability of Google Drive integration
  • Code includes detailed comments and docstrings for maintainability

Contribution by Gittensor, learn more at https://gittensor.io/

**Original Pull Request:** https://github.com/langgenius/dify/pull/28849 **State:** closed **Merged:** No --- # Add Comprehensive Unit Tests for Google Drive Datasource Provider > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary This PR adds comprehensive unit tests for the Google Drive datasource provider, ensuring robust coverage of all core functionality including OAuth authentication, file operations, and incremental sync capabilities. ### Fixes Closes https://github.com/langgenius/dify/issues/28848 ### What's Changed - **New Test File**: `api/tests/unit_tests/core/datasource/test_google_drive_provider.py` - **Total Tests**: 45 comprehensive test cases - **Test Coverage**: 100% of Google Drive provider functionality ### Test Categories 1. **OAuth Authentication** (5 tests) - OAuth2 token initialization and management - Token refresh on expiry - Credential encryption handling - Missing credentials scenarios 2. **File Listing** (5 tests) - Root folder browsing - Pagination with page tokens - Subfolder/bucket navigation - Empty folder handling - Various file types and sizes 3. **File Download** (5 tests) - Single file download - Downloads from specific buckets - Large file streaming - Binary and text file handling 4. **Incremental Sync** (5 tests) - Modified file detection - No-change scenarios - Pagination in sync operations - Deleted file tracking - Full vs incremental sync comparison 5. **Provider Controller** (6 tests) - Provider initialization - Datasource retrieval - Credential requirements - Error handling for missing datasources 6. **Error Handling** (4 tests) - Authentication failures - Invalid file IDs - Rate limiting - Network errors 7. **Advanced Scenarios** (9 tests) - Shared drives (Team Drives) - Google Workspace files (Docs, Sheets, Slides) - Unicode and special characters in filenames - Deep pagination (50+ files) - Mixed content types - Comprehensive file metadata - Multiple change type tracking - Concurrent operations 8. **Edge Cases** (6 tests) - Zero-byte files - Extremely long filenames (255+ chars) - Files without extensions - Duplicate filenames in different folders - Deeply nested folder structures - Empty file downloads ### Key Features - ✅ **Well-documented**: Comprehensive docstrings and inline comments for better code understanding - ✅ **Follows TDD**: Arrange-Act-Assert pattern throughout - ✅ **No external dependencies**: All tests use mocking for fast, reliable execution - ✅ **Ruff lint compliant**: All code quality checks pass - ✅ **Fast execution**: All 45 tests run in ~33 seconds ### Testing Results ```bash # All tests pass $ uv run --project api pytest api/tests/unit_tests/core/datasource/test_google_drive_provider.py -v 45 passed in 33.07s # Ruff lint passes $ uv run --project api ruff check api/tests/unit_tests/core/datasource/test_google_drive_provider.py All checks passed! ``` ## Screenshots Not applicable - this PR adds test coverage only, no UI changes. ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods ## Additional Notes - All tests follow existing Dify project testing conventions - Tests are isolated and don't require external Google Drive API access - Comprehensive coverage ensures reliability of Google Drive integration - Code includes detailed comments and docstrings for maintainability Contribution by Gittensor, learn more at https://gittensor.io/
yindo added the pull-request label 2026-02-21 20:50:57 -05:00
yindo closed this issue 2026-02-21 20:50:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32207
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?