langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #28854] test: add comprehensive unit tests for TagService #32210

New Issue
Closed
opened 2026-02-21 20:50:58 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:50:58 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/28854

State: closed
Merged: Yes

  • Add 24 unit tests covering tag retrieval, CRUD, and binding operations
  • Test scenarios include:
    • Tag retrieval with binding counts
    • Keyword filtering (case-insensitive search)
    • Get tags by target ID (apps/datasets)
    • Get tags by name
    • Get target IDs by tag IDs
    • Create tags with duplicate name validation
    • Update tags with duplicate name validation
    • Delete tags with cascade deletion of bindings
    • Get tag binding counts
    • Save tag bindings (idempotent)
    • Delete tag bindings (safe deletion)
    • Target validation (app/dataset existence)
    • NotFound error handling
    • Invalid binding type validation
  • Use factory pattern for mock data creation
  • All tests follow Arrange-Act-Assert structure
  • Tests pass lint, type-check, and pytest validation
  • Coverage: 11 methods across 3 test classes

Fixes #28852

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...
diffy_unit_test

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/28854 **State:** closed **Merged:** Yes --- - Add 24 unit tests covering tag retrieval, CRUD, and binding operations - Test scenarios include: * Tag retrieval with binding counts * Keyword filtering (case-insensitive search) * Get tags by target ID (apps/datasets) * Get tags by name * Get target IDs by tag IDs * Create tags with duplicate name validation * Update tags with duplicate name validation * Delete tags with cascade deletion of bindings * Get tag binding counts * Save tag bindings (idempotent) * Delete tag bindings (safe deletion) * Target validation (app/dataset existence) * NotFound error handling * Invalid binding type validation - Use factory pattern for mock data creation - All tests follow Arrange-Act-Assert structure - Tests pass lint, type-check, and pytest validation - Coverage: 11 methods across 3 test classes Fixes #28852 > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ## Screenshots | Before | After | |--------|-------| | ... | ... | <img width="927" height="869" alt="diffy_unit_test" src="https://github.com/user-attachments/assets/f9a3a180-e97b-4107-8d6e-61bf5119d3dd" /> ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:50:58 -05:00
yindo closed this issue 2026-02-21 20:50:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32210
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?