langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #28905] feat: add comprehensive integration tests for workflow performance analytics #32231

New Issue
Closed
opened 2026-02-21 20:51:00 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:00 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/28905

State: closed
Merged: No

Add test suite with 26 test methods covering:

Core Integration Tests (19 tests):

  • End-to-end workflow execution tracking
  • Cache hit/miss scenarios and statistics
  • Bottleneck detection with varying performance
  • Optimization recommendation generation and dismissal
  • Concurrent workflow executions
  • Cache expiration and cleanup mechanisms
  • Performance degradation detection over time
  • Multi-workflow isolation
  • Cache invalidation by node type and workflow
  • Node performance breakdown accuracy
  • Recommendation priority and severity filtering
  • Error handling with invalid data
  • Cache key generation consistency
  • Time-series performance trends analysis
  • Large-scale cache operations (100+ entries)
  • Recommendation deduplication
  • Node execution status tracking
  • Cache data integrity with complex nested structures
  • Performance percentile calculations (P50, P95, P99)

Edge Cases & Error Handling (7 tests):

  • Empty workflow scenarios
  • Null value handling
  • Very large token counts (1M+)
  • Zero-duration executions
  • Recommendations with missing fields
  • Cache statistics with no entries
  • Single node bottleneck detection

Test Classes:

  • TestWorkflowPerformanceIntegration (19 tests)
  • TestEdgeCasesAndErrorHandling (7 tests)

Note: These tests are designed to run after the workflow performance analytics feature (PR #28883) is merged into main.

Fixes #28904

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/28905 **State:** closed **Merged:** No --- Add test suite with 26 test methods covering: Core Integration Tests (19 tests): - End-to-end workflow execution tracking - Cache hit/miss scenarios and statistics - Bottleneck detection with varying performance - Optimization recommendation generation and dismissal - Concurrent workflow executions - Cache expiration and cleanup mechanisms - Performance degradation detection over time - Multi-workflow isolation - Cache invalidation by node type and workflow - Node performance breakdown accuracy - Recommendation priority and severity filtering - Error handling with invalid data - Cache key generation consistency - Time-series performance trends analysis - Large-scale cache operations (100+ entries) - Recommendation deduplication - Node execution status tracking - Cache data integrity with complex nested structures - Performance percentile calculations (P50, P95, P99) Edge Cases & Error Handling (7 tests): - Empty workflow scenarios - Null value handling - Very large token counts (1M+) - Zero-duration executions - Recommendations with missing fields - Cache statistics with no entries - Single node bottleneck detection Test Classes: - TestWorkflowPerformanceIntegration (19 tests) - TestEdgeCasesAndErrorHandling (7 tests) Note: These tests are designed to run after the workflow performance analytics feature (PR #28883) is merged into main. Fixes #28904 > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:51:00 -05:00
yindo closed this issue 2026-02-21 20:51:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32231
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?