langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #28946] Add file upload enabled check and new i18n message #32249

New Issue
Closed
opened 2026-02-21 20:51:02 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:02 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/28946

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes # 28945.

Summary

I fixed #28945 .
The current implementation allows files to be uploaded via drag-and-drop even when the file upload feature is explicitly disabled in the configuration.

Root Cause

The issue arises because the system only checks for allowed file types (e.g., image extensions) before uploading, but does not check if the entire feature is enabled.
https://github.com/langgenius/dify/blob/247069c7e96fa1763fc9dd9da001bc5683c73a64/web/app/components/base/file-uploader/hooks.ts#L249
Since image types are allowed by default, fileConfig.allowed_file_types includes images. Consequently, even when the file upload feature is disabled (fileConfig.enabled: false), the isAllowedFileExtension function returns True, allowing the upload process to proceed.

Fix

  1. Enforced Feature Check: Added a condition to the handleLocalFileUpload function to check the status of fileConfig.enabled. If it is false, the function now immediately returns an error.

  2. Improved Error Messaging: Introduced a clearer error message for when file uploads are disabled.

  3. Code Cleanup: Removed redundant checks in the clipboard handling logic to standardize the error message and streamline the process, ensuring consistent behavior across different upload methods.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/28946 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes # 28945`. ## Summary I fixed #28945 . The current implementation allows files to be uploaded via drag-and-drop even when the file upload feature is explicitly disabled in the configuration. ### Root Cause The issue arises because the system only checks for allowed file types (e.g., image extensions) before uploading, but does not check if the entire feature is enabled. https://github.com/langgenius/dify/blob/247069c7e96fa1763fc9dd9da001bc5683c73a64/web/app/components/base/file-uploader/hooks.ts#L249 Since image types are allowed by default, fileConfig.allowed_file_types includes images. Consequently, even when the file upload feature is disabled (fileConfig.enabled: false), the isAllowedFileExtension function returns True, allowing the upload process to proceed. ### Fix 1. Enforced Feature Check: Added a condition to the handleLocalFileUpload function to check the status of fileConfig.enabled. If it is false, the function now immediately returns an error. 2. Improved Error Messaging: Introduced a clearer error message for when file uploads are disabled. 3. Code Cleanup: Removed redundant checks in the clipboard handling logic to standardize the error message and streamline the process, ensuring consistent behavior across different upload methods. ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:51:02 -05:00
yindo closed this issue 2026-02-21 20:51:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?