langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #28977] fix(web): use atomic selectors to fix Zustand v5 infinite loop #32259

New Issue
Closed
opened 2026-02-21 20:51:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:03 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/28977

State: closed
Merged: Yes

Fixes #28976

Summary

After upgrading Zustand from v4.5.7 to v5.0.9, workflow test run triggers an infinite loop error:

The result of getSnapshot should be cached to avoid an infinite loop

Root cause: Zustand v5 uses React 18's useSyncExternalStore which actively detects unstable selector outputs. Selectors returning new objects/arrays on every call are now caught and throw errors, whereas v4's custom subscription mechanism allowed this as a silent performance bug (infinite re-renders without crashing).

Solution: Replace object-returning selectors with atomic selectors (Zustand recommended best practice).

- const { inputs, setInputs } = useStore(s => ({
-   inputs: s.inputs,
-   setInputs: s.setInputs,
- }))
+ const inputs = useStore(s => s.inputs)
+ const setInputs = useStore(s => s.setInputs)

Files changed:

  • web/app/components/workflow/panel/inputs-panel.tsx
  • web/app/components/workflow/panel/debug-and-preview/chat-wrapper.tsx

Screenshots

Before After
Console error: infinite loop No errors

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/28977 **State:** closed **Merged:** Yes --- Fixes #28976 ## Summary After upgrading Zustand from v4.5.7 to v5.0.9, workflow test run triggers an infinite loop error: ``` The result of getSnapshot should be cached to avoid an infinite loop ``` **Root cause**: Zustand v5 uses React 18's `useSyncExternalStore` which actively detects unstable selector outputs. Selectors returning new objects/arrays on every call are now caught and throw errors, whereas v4's custom subscription mechanism allowed this as a silent performance bug (infinite re-renders without crashing). **Solution**: Replace object-returning selectors with atomic selectors (Zustand recommended best practice). ```diff - const { inputs, setInputs } = useStore(s => ({ - inputs: s.inputs, - setInputs: s.setInputs, - })) + const inputs = useStore(s => s.inputs) + const setInputs = useStore(s => s.setInputs) ``` **Files changed**: - `web/app/components/workflow/panel/inputs-panel.tsx` - `web/app/components/workflow/panel/debug-and-preview/chat-wrapper.tsx` ## Screenshots | Before | After | |--------|-------| | Console error: infinite loop | No errors | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:51:03 -05:00
yindo closed this issue 2026-02-21 20:51:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?