langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #29417] Fix immediate window open defaults and error handling #32410

New Issue
Closed
opened 2026-02-21 20:51:21 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:21 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/29417

State: closed
Merged: Yes

Summary

  • Immediate window opens were not defaulting to noopener,noreferrer and left opener intact, leaving a tabnabbing vector for direct links; the branch also ignored popup failures.
  • Apply safe defaults (noopener,noreferrer), clear opener, and invoke onError when window.open returns null so async URL fetch is skipped after a blocked popup.
  • Async placeholder flow stays as-is; new tests cover the immediate-path opener clearing and blocked-window error reporting.

Testing

  • pnpm type-check:tsgo
  • pnpm test -- use-async-window-open.spec.ts
**Original Pull Request:** https://github.com/langgenius/dify/pull/29417 **State:** closed **Merged:** Yes --- ## Summary - Immediate window opens were not defaulting to `noopener,noreferrer` and left `opener` intact, leaving a tabnabbing vector for direct links; the branch also ignored popup failures. - Apply safe defaults (`noopener,noreferrer`), clear `opener`, and invoke `onError` when `window.open` returns `null` so async URL fetch is skipped after a blocked popup. - Async placeholder flow stays as-is; new tests cover the immediate-path opener clearing and blocked-window error reporting. ## Testing - pnpm type-check:tsgo - pnpm test -- use-async-window-open.spec.ts
yindo added the pull-request label 2026-02-21 20:51:21 -05:00
yindo closed this issue 2026-02-21 20:51:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32410
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?