langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #29617] fix: add BILLING_ENABLED check to delete_account_task #32488

New Issue
Closed
opened 2026-02-21 20:51:30 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:30 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/29617

State: closed
Merged: No

Summary

  • Add BILLING_ENABLED check before calling BillingService.delete_account() in delete_account_task
  • Prevents errors in self-hosted deployments where billing is disabled

Fixes #29557

Test plan

  • Added unit tests for delete_account_task
  • Tests verify BillingService is called when BILLING_ENABLED=True
  • Tests verify BillingService is skipped when BILLING_ENABLED=False
  • All tests pass locally
**Original Pull Request:** https://github.com/langgenius/dify/pull/29617 **State:** closed **Merged:** No --- ## Summary - Add `BILLING_ENABLED` check before calling `BillingService.delete_account()` in `delete_account_task` - Prevents errors in self-hosted deployments where billing is disabled Fixes #29557 ## Test plan - [x] Added unit tests for `delete_account_task` - [x] Tests verify BillingService is called when BILLING_ENABLED=True - [x] Tests verify BillingService is skipped when BILLING_ENABLED=False - [x] All tests pass locally
yindo added the pull-request label 2026-02-21 20:51:30 -05:00
yindo closed this issue 2026-02-21 20:51:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?