langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #29618] fix: preserve empty list for FILE_LIST type in base_app_generator #32490

New Issue
Closed
opened 2026-02-21 20:51:30 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:30 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/29618

State: closed
Merged: Yes

Summary

  • Preserve empty lists [] for optional FILE_LIST variables instead of converting to None
  • Empty strings are still treated as unset (returns None)
  • Prevents downstream components like document_extractor from failing with "unsupported variable type"

Fixes #29598

Test plan

  • Updated test test_validate_inputs_optional_file_list_with_empty_list to expect [] instead of None
  • Added new test test_validate_inputs_optional_file_list_with_empty_string to verify empty string returns None
  • All 8 tests in test_base_app_generator.py pass
**Original Pull Request:** https://github.com/langgenius/dify/pull/29618 **State:** closed **Merged:** Yes --- ## Summary - Preserve empty lists `[]` for optional FILE_LIST variables instead of converting to `None` - Empty strings are still treated as unset (returns `None`) - Prevents downstream components like `document_extractor` from failing with "unsupported variable type" Fixes #29598 ## Test plan - [x] Updated test `test_validate_inputs_optional_file_list_with_empty_list` to expect `[]` instead of `None` - [x] Added new test `test_validate_inputs_optional_file_list_with_empty_string` to verify empty string returns `None` - [x] All 8 tests in `test_base_app_generator.py` pass
yindo added the pull-request label 2026-02-21 20:51:30 -05:00
yindo closed this issue 2026-02-21 20:51:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32490
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?