langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #29667] test: Add comprehensive Jest test for AppCard component #32507

New Issue
Closed
opened 2026-02-21 20:51:32 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:32 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/29667

State: closed
Merged: Yes

Summary

  • add comprehensive RTL/Jest spec for AppCard covering modes, icon variants, create CTA, accessibility and edge cases
  • wire canCreate prop to actually gate rendering of the template CTA overlay
  • keep component DOM clean (no data-* hooks) by using semantic queries in tests

Testing

  • pnpm test -- app/components/app/create-app-dialog/app-card/index.spec.tsx
**Original Pull Request:** https://github.com/langgenius/dify/pull/29667 **State:** closed **Merged:** Yes --- ## Summary - add comprehensive RTL/Jest spec for AppCard covering modes, icon variants, create CTA, accessibility and edge cases - wire canCreate prop to actually gate rendering of the template CTA overlay - keep component DOM clean (no data-* hooks) by using semantic queries in tests ## Testing - pnpm test -- app/components/app/create-app-dialog/app-card/index.spec.tsx
yindo added the pull-request label 2026-02-21 20:51:32 -05:00
yindo closed this issue 2026-02-21 20:51:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?