langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #29709] test: add comprehensive tests for CustomizeModal component #32526

New Issue
Closed
opened 2026-02-21 20:51:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/29709

State: closed
Merged: Yes

Summary

  • Add comprehensive Jest tests for app/components/app/overview/customize/ component
  • 25 test cases covering all aspects of the CustomizeModal
  • Remove unused linkUrl prop from component and its usage

Test Coverage

Metric Coverage
Statements 100%
Branches 100%
Functions 100%
Lines 100%

Test Scenarios

  • Rendering: Modal title, description, tags, step numbers, instructions, env variables
  • Props: appId and api_base_url display correctly in environment config
  • Mode-based GitHub link: All 5 AppModeEnum values tested (CHAT, ADVANCED_CHAT, COMPLETION, WORKFLOW, AGENT_CHAT)
  • External links: GitHub and Vercel links with correct security attributes
  • User Interactions: Way 2 button opens documentation, modal close button
  • Edge Cases: Empty values, special characters
  • StepNum component: Styling verification
  • GithubIcon component: SVG rendering

Test plan

  • All 25 tests pass
  • Type check passes (pnpm type-check:tsgo)
  • ESLint passes
**Original Pull Request:** https://github.com/langgenius/dify/pull/29709 **State:** closed **Merged:** Yes --- ## Summary - Add comprehensive Jest tests for `app/components/app/overview/customize/` component - 25 test cases covering all aspects of the CustomizeModal - Remove unused `linkUrl` prop from component and its usage ## Test Coverage | Metric | Coverage | |--------|----------| | Statements | 100% | | Branches | 100% | | Functions | 100% | | Lines | 100% | ## Test Scenarios - **Rendering**: Modal title, description, tags, step numbers, instructions, env variables - **Props**: appId and api_base_url display correctly in environment config - **Mode-based GitHub link**: All 5 AppModeEnum values tested (CHAT, ADVANCED_CHAT, COMPLETION, WORKFLOW, AGENT_CHAT) - **External links**: GitHub and Vercel links with correct security attributes - **User Interactions**: Way 2 button opens documentation, modal close button - **Edge Cases**: Empty values, special characters - **StepNum component**: Styling verification - **GithubIcon component**: SVG rendering ## Test plan - [x] All 25 tests pass - [x] Type check passes (`pnpm type-check:tsgo`) - [x] ESLint passes
yindo added the pull-request label 2026-02-21 20:51:34 -05:00
yindo closed this issue 2026-02-21 20:51:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32526
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?