langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #29826] fix(theme): make sticky headers opaque in dark mode (Monaco sticky sc… #32567

New Issue
Closed
opened 2026-02-21 20:51:39 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:39 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/29826

State: closed
Merged: Yes

…roll + app sticky headers)

Related Issue

Closes #29359

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Added new sticky-specific variables to [dark.css]):
--color-components-sticky-header-bg (uses panel bg)
--color-components-sticky-header-bg-hover
--color-components-sticky-header-border
Overrode Monaco variables:
--vscode-editorStickyScroll-background
--vscode-editorStickyScrollHover-background
--vscode-editorStickyScroll-border
--vscode-editorStickyScroll-shadow
Added a small CSS file [monaco-sticky-fix.css] that explicitly styles Monaco’s [.sticky-widget] in dark mode to use the solid sticky background and border (with important flags to be safe).
Imported the new CSS in [globals.css].
Committed as: "fix(theme): make sticky headers opaque in dark mode (Monaco sticky scroll + app sticky headers)" and pushed the branch.
Why this fixes it 💡

Previously the dark theme used very low-opacity white for input backgrounds (e.g., rgb(255 255 255 / 0.08)), which looked invisible when elements became sticky.
The changes make sticky header backgrounds use a solid panel color (or panel-hover color on hover), ensuring good contrast and visibility.
Monaco's sticky-scroll CSS uses CSS vars like [--vscode-editorStickyScroll-background], so overriding those in the theme ensures the editor's sticky header is corrected too.

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/29826 **State:** closed **Merged:** Yes --- …roll + app sticky headers) ## Related Issue Closes #29359 > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary Added new sticky-specific variables to [dark.css]): --color-components-sticky-header-bg (uses panel bg) --color-components-sticky-header-bg-hover --color-components-sticky-header-border Overrode Monaco variables: --vscode-editorStickyScroll-background --vscode-editorStickyScrollHover-background --vscode-editorStickyScroll-border --vscode-editorStickyScroll-shadow Added a small CSS file [monaco-sticky-fix.css] that explicitly styles Monaco’s [.sticky-widget] in dark mode to use the solid sticky background and border (with important flags to be safe). Imported the new CSS in [globals.css]. Committed as: "fix(theme): make sticky headers opaque in dark mode (Monaco sticky scroll + app sticky headers)" and pushed the branch. Why this fixes it 💡 Previously the dark theme used very low-opacity white for input backgrounds (e.g., rgb(255 255 255 / 0.08)), which looked invisible when elements became sticky. The changes make sticky header backgrounds use a solid panel color (or panel-hover color on hover), ensuring good contrast and visibility. Monaco's sticky-scroll CSS uses CSS vars like [--vscode-editorStickyScroll-background], so overriding those in the theme ensures the editor's sticky header is corrected too. ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `dev/reformat`(backend) and `cd web && npx lint-staged`(frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:51:39 -05:00
yindo closed this issue 2026-02-21 20:51:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32567
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?