langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 12:36:14 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30096] feat(web): add unit tests for Badge component #32684

New Issue
Closed
opened 2026-02-21 20:51:53 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:53 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30096

State: closed
Merged: Yes

What's this PR about?

Hey there! 👋

I noticed the Badge component was missing test coverage, so I went ahead and added a comprehensive test suite for it.

What's covered?

  • ✅ Basic rendering and children display
  • ✅ All three size variants (s, m, l)
  • ✅ State variants (Warning, Accent, Default)
  • ✅ iconOnly padding behavior for each size
  • ✅ uppercase text styling
  • ✅ Custom styleCss and className support
  • ✅ HTML attributes passthrough (data-*, id, aria-*, title)
  • ✅ Combined props scenarios

Test results

All 25 tests pass! 🎉

Related

This follows the same testing patterns used in button/index.spec.tsx, keeping things consistent across base components.

Happy to make any changes if needed!

**Original Pull Request:** https://github.com/langgenius/dify/pull/30096 **State:** closed **Merged:** Yes --- ## What's this PR about? Hey there! 👋 I noticed the Badge component was missing test coverage, so I went ahead and added a comprehensive test suite for it. ## What's covered? - ✅ Basic rendering and children display - ✅ All three size variants (`s`, `m`, `l`) - ✅ State variants (`Warning`, `Accent`, `Default`) - ✅ `iconOnly` padding behavior for each size - ✅ `uppercase` text styling - ✅ Custom `styleCss` and `className` support - ✅ HTML attributes passthrough (`data-*`, `id`, `aria-*`, `title`) - ✅ Combined props scenarios ## Test results All 25 tests pass! 🎉 ## Related This follows the same testing patterns used in `button/index.spec.tsx`, keeping things consistent across base components. --- Happy to make any changes if needed!
yindo added the pull-request label 2026-02-21 20:51:53 -05:00
yindo closed this issue 2026-02-21 20:51:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32684
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?