langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30121] fix: trigger subscription delete not working for non-auto-created credentials #32695

New Issue
Closed
opened 2026-02-21 20:51:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:54 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30121

State: closed
Merged: No

Summary

  • Fix trigger subscription delete not working for non-auto-created credentials
  • The delete_subscription method was returning early when credential_type was not OAUTH2 or API_KEY
  • Now the subscription is always deleted from database regardless of credential type

Changes

  • Moved the early return logic to only skip the unsubscribe_trigger call for non-auto-created credentials
  • Ensured session.delete(subscription) is always executed

Closes #30120

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/langgenius/dify/pull/30121 **State:** closed **Merged:** No --- ## Summary - Fix trigger subscription delete not working for non-auto-created credentials - The `delete_subscription` method was returning early when credential_type was not OAUTH2 or API_KEY - Now the subscription is always deleted from database regardless of credential type ## Changes - Moved the early return logic to only skip the `unsubscribe_trigger` call for non-auto-created credentials - Ensured `session.delete(subscription)` is always executed Closes #30120 🤖 Generated with [Claude Code](https://claude.com/claude-code)
yindo added the pull-request label 2026-02-21 20:51:54 -05:00
yindo closed this issue 2026-02-21 20:51:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32695
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?