langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 21:15:32 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30119] test: Add comprehensive test suite for Chip component #32696

New Issue
Closed
opened 2026-02-21 20:51:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:54 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30119

State: closed
Merged: Yes

🎯 What's this about?

Hey there! 👋 I noticed our Chip component was missing test coverage, so I spent some time writing a comprehensive test suite for it.

✨ What I did

I wrote 26 test cases that cover pretty much everything the Chip component does:

  • Rendering tests: Making sure it shows up correctly with different values
  • Props testing: All the different ways you can configure it (icons, styles, etc.)
  • State management: Opening/closing the dropdown, selecting items
  • Event handling: Clicks, selections, and that tricky clear button behavior
  • Edge cases: Empty arrays, invalid values, rapid clicking, and numeric values

📊 Coverage

I'm happy to report we hit some solid numbers:

  • ✅ 100% statement coverage
  • ✅ 100% function coverage
  • ✅ 100% line coverage
  • ✅ 96.15% branch coverage (just one tiny edge case uncovered at line 56)

🛠️ Technical details

  • Used semantic queries (role, getByText) instead of test IDs where possible for better accessibility testing
  • Added proper TypeScript interfaces for all mocks (no more any types!)
  • Created helper functions (renderChip, openPanel) to keep tests DRY
  • Fixed a few tricky issues with querying duplicate elements using within()

✅ All checks passed

  • ESLint: ✓
  • TypeScript: ✓
  • Unit tests: ✓ (26/26 passing)

Hope this helps improve our test coverage! Let me know if you'd like me to adjust anything. 😊

**Original Pull Request:** https://github.com/langgenius/dify/pull/30119 **State:** closed **Merged:** Yes --- ## 🎯 What's this about? Hey there! 👋 I noticed our Chip component was missing test coverage, so I spent some time writing a comprehensive test suite for it. ## ✨ What I did I wrote **26 test cases** that cover pretty much everything the Chip component does: - **Rendering tests**: Making sure it shows up correctly with different values - **Props testing**: All the different ways you can configure it (icons, styles, etc.) - **State management**: Opening/closing the dropdown, selecting items - **Event handling**: Clicks, selections, and that tricky clear button behavior - **Edge cases**: Empty arrays, invalid values, rapid clicking, and numeric values ## 📊 Coverage I'm happy to report we hit some solid numbers: - ✅ **100%** statement coverage - ✅ **100%** function coverage - ✅ **100%** line coverage - ✅ **96.15%** branch coverage (just one tiny edge case uncovered at line 56) ## 🛠️ Technical details - Used semantic queries (`role`, `getByText`) instead of test IDs where possible for better accessibility testing - Added proper TypeScript interfaces for all mocks (no more `any` types!) - Created helper functions (`renderChip`, `openPanel`) to keep tests DRY - Fixed a few tricky issues with querying duplicate elements using `within()` ## ✅ All checks passed - ESLint: ✓ - TypeScript: ✓ - Unit tests: ✓ (26/26 passing) Hope this helps improve our test coverage! Let me know if you'd like me to adjust anything. 😊
yindo added the pull-request label 2026-02-21 20:51:54 -05:00
yindo closed this issue 2026-02-21 20:51:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32696
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?