langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-22 04:25:29 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30138] fix(web): correct deleted tools matching to use provider_id instead of id #32697

New Issue
Closed
opened 2026-02-21 20:51:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:54 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30138

State: closed
Merged: Yes

Summary

  • Fixed the deleted tools matching logic in agent configuration
  • Changed deletedTool.id === tool.id to deletedTool.provider_id === tool.provider_id
  • Backend deleted_tools response contains provider_id, not id, causing matching to fail

Root Cause

The backend API returns deleted_tools with fields: type, tool_name, provider_id (see api/fields/app_fields.py:171-175). The frontend was incorrectly trying to match using deletedTool.id which doesn't exist.

Test plan

  • Verified agent-tools unit tests pass
  • Fix matches backend field structure

fixes #30048

**Original Pull Request:** https://github.com/langgenius/dify/pull/30138 **State:** closed **Merged:** Yes --- ## Summary - Fixed the deleted tools matching logic in agent configuration - Changed `deletedTool.id === tool.id` to `deletedTool.provider_id === tool.provider_id` - Backend `deleted_tools` response contains `provider_id`, not `id`, causing matching to fail ## Root Cause The backend API returns `deleted_tools` with fields: `type`, `tool_name`, `provider_id` (see `api/fields/app_fields.py:171-175`). The frontend was incorrectly trying to match using `deletedTool.id` which doesn't exist. ## Test plan - [x] Verified agent-tools unit tests pass - [x] Fix matches backend field structure fixes #30048
yindo added the pull-request label 2026-02-21 20:51:54 -05:00
yindo closed this issue 2026-02-21 20:51:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32697
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?