langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30131] fix(web): add null check for SSE stream bufferObj to prevent TypeError #32699

New Issue
Closed
opened 2026-02-21 20:51:54 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:54 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30131

State: closed
Merged: Yes

Summary

  • Added null/type validation for bufferObj after JSON.parse in handleStream function
  • Prevents TypeError when server returns null or non-object data in SSE stream
  • Added comprehensive test coverage for the fix

Test plan

  • Added unit tests for null bufferObj handling
  • Added unit tests for non-object bufferObj handling
  • Added unit tests for valid message event handling
  • Added unit tests for error status 400 handling
  • Added unit tests for malformed JSON handling
  • All new tests pass locally

fixes #29166

**Original Pull Request:** https://github.com/langgenius/dify/pull/30131 **State:** closed **Merged:** Yes --- ## Summary - Added null/type validation for `bufferObj` after JSON.parse in `handleStream` function - Prevents TypeError when server returns `null` or non-object data in SSE stream - Added comprehensive test coverage for the fix ## Test plan - [x] Added unit tests for null bufferObj handling - [x] Added unit tests for non-object bufferObj handling - [x] Added unit tests for valid message event handling - [x] Added unit tests for error status 400 handling - [x] Added unit tests for malformed JSON handling - [x] All new tests pass locally fixes #29166
yindo added the pull-request label 2026-02-21 20:51:54 -05:00
yindo closed this issue 2026-02-21 20:51:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32699
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?