langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30229] fix: consolidate duplicate InvokeRateLimitError definitions #32736

New Issue
Closed
opened 2026-02-21 20:51:58 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:51:58 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30229

State: closed
Merged: Yes

Summary

  • Remove duplicate InvokeRateLimitError from services/errors/app.py
  • Use services.errors.llm.InvokeRateLimitError in app_generate_service.py for sync user requests (has description attribute for HTTP responses)
  • Add WorkflowQuotaLimitError in services/errors/app.py for async workflow execution (simple Exception for background processing)
  • Update async_workflow_service.py to use WorkflowQuotaLimitError

Closes #30228

Test plan

  • Verify make lint passes
  • Verify make type-check passes
  • Test rate limit scenario returns HTTP 429 instead of 500
**Original Pull Request:** https://github.com/langgenius/dify/pull/30229 **State:** closed **Merged:** Yes --- ## Summary - Remove duplicate `InvokeRateLimitError` from `services/errors/app.py` - Use `services.errors.llm.InvokeRateLimitError` in `app_generate_service.py` for sync user requests (has `description` attribute for HTTP responses) - Add `WorkflowQuotaLimitError` in `services/errors/app.py` for async workflow execution (simple Exception for background processing) - Update `async_workflow_service.py` to use `WorkflowQuotaLimitError` Closes #30228 ## Test plan - [ ] Verify `make lint` passes - [ ] Verify `make type-check` passes - [ ] Test rate limit scenario returns HTTP 429 instead of 500
yindo added the pull-request label 2026-02-21 20:51:58 -05:00
yindo closed this issue 2026-02-21 20:51:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32736
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?