langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30333] fix(api): surface subscription deletion errors to users #32778

New Issue
Closed
opened 2026-02-21 20:52:03 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:03 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30333

State: closed
Merged: Yes

Summary

This PR fixes a bug where trigger subscription deletion/unsubscribe errors were silently ignored during the rebuild process.

  • Check UnsubscribeResult.success and propagate error messages to users when unsubscribe fails
  • Simplify rebuild logic by removing unnecessary try/except wrapper around unsubscribe
  • Refactor update API to use cleaner conditional logic with any()
  • Remove redundant test cases that validated silent error handling behavior

Fixes #30332

Test Plan

  • Verify that unsubscribe errors are now properly surfaced to users with clear error messages
  • Verify that successful subscription rebuilds continue to work as expected
  • Run existing unit tests to ensure no regressions
**Original Pull Request:** https://github.com/langgenius/dify/pull/30333 **State:** closed **Merged:** Yes --- ## Summary This PR fixes a bug where trigger subscription deletion/unsubscribe errors were silently ignored during the rebuild process. - Check `UnsubscribeResult.success` and propagate error messages to users when unsubscribe fails - Simplify rebuild logic by removing unnecessary try/except wrapper around unsubscribe - Refactor update API to use cleaner conditional logic with `any()` - Remove redundant test cases that validated silent error handling behavior Fixes #30332 ## Test Plan - [x] Verify that unsubscribe errors are now properly surfaced to users with clear error messages - [x] Verify that successful subscription rebuilds continue to work as expected - [x] Run existing unit tests to ensure no regressions
yindo added the pull-request label 2026-02-21 20:52:03 -05:00
yindo closed this issue 2026-02-21 20:52:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32778
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?