langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 03:55:25 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30368] fix(i18n): load server namespaces by kebab-case #32791

New Issue
Closed
opened 2026-02-21 20:52:05 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:05 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30368

State: closed
Merged: Yes

Summary

  • Load server i18n JSON files by kebab-case filenames while keeping camelCase namespaces internally.

Context

After PR #30336, getTranslation camelCases namespaces before calling loadNamespaces. The server backend then builds import paths like ../i18n/${language}/${namespace}.json, which becomes datasetSettings.json for dataset-settings. That file doesn't exist, so server translations for dashed namespaces fail.

Repro

  1. Ensure the locale cookie is set (e.g., zh-Hans).
  2. Open /datasets/<id>/settings (uses dataset-settings).
  3. Server tries to load datasetSettings.json and misses; translations fall back to keys.

Fix

  • Convert the backend namespace to kebab-case before building the import path.
**Original Pull Request:** https://github.com/langgenius/dify/pull/30368 **State:** closed **Merged:** Yes --- ## Summary - Load server i18n JSON files by kebab-case filenames while keeping camelCase namespaces internally. ## Context After PR #30336, `getTranslation` camelCases namespaces before calling `loadNamespaces`. The server backend then builds import paths like `../i18n/${language}/${namespace}.json`, which becomes `datasetSettings.json` for `dataset-settings`. That file doesn't exist, so server translations for dashed namespaces fail. ## Repro 1. Ensure the locale cookie is set (e.g., `zh-Hans`). 2. Open `/datasets/<id>/settings` (uses `dataset-settings`). 3. Server tries to load `datasetSettings.json` and misses; translations fall back to keys. ## Fix - Convert the backend `namespace` to kebab-case before building the import path.
yindo added the pull-request label 2026-02-21 20:52:05 -05:00
yindo closed this issue 2026-02-21 20:52:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32791
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?