langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30397] fix(web): migrate es-toolkit/compat API (uniqueId & isEmpty) #32801

New Issue
Closed
opened 2026-02-21 20:52:06 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:06 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30397

State: closed
Merged: No

Summary

  • Replace uniqueId from es-toolkit/compat with native implementation
  • Replace isEmpty from es-toolkit/compat with native implementation
  • Add utility functions in web/utils/toolkit-helpers.ts

Changes

  • uniqueId: simple counter-based ID generator
  • isEmpty: checks null, arrays, strings, Maps, Sets, objects

Test plan

  • Add unit tests for uniqueId (3 tests)
  • Add unit tests for isEmpty (12 tests)
  • All 15 tests pass
  • pnpm type-check:tsgo passes
  • pnpm lint passes

Fixes #30245

**Original Pull Request:** https://github.com/langgenius/dify/pull/30397 **State:** closed **Merged:** No --- ## Summary - Replace `uniqueId` from es-toolkit/compat with native implementation - Replace `isEmpty` from es-toolkit/compat with native implementation - Add utility functions in `web/utils/toolkit-helpers.ts` ## Changes - `uniqueId`: simple counter-based ID generator - `isEmpty`: checks null, arrays, strings, Maps, Sets, objects ## Test plan - [x] Add unit tests for `uniqueId` (3 tests) - [x] Add unit tests for `isEmpty` (12 tests) - [x] All 15 tests pass - [x] `pnpm type-check:tsgo` passes - [x] `pnpm lint` passes Fixes #30245
yindo added the pull-request label 2026-02-21 20:52:06 -05:00
yindo closed this issue 2026-02-21 20:52:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32801
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?