langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30442] fix(web): stop thinking timer when user clicks stop button #32817

New Issue
Closed
opened 2026-02-21 20:52:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:08 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30442

State: closed
Merged: Yes

Summary

  • Fix the issue where the thinking timer continues to run after user clicks stop button
  • The timer now properly stops when isResponding is explicitly set to false

Changes

  • Modified the condition to check for isResponding === false instead of !isResponding
  • This distinguishes between explicit stop (false) and undefined context (when component is used outside ChatContextProvider)
  • Added comprehensive tests for the ThinkBlock component

Test plan

  • New unit tests for ThinkBlock component pass
  • Type check passes (pnpm type-check:tsgo)
  • Lint check passes (pnpm lint:fix)

fixes #20679

**Original Pull Request:** https://github.com/langgenius/dify/pull/30442 **State:** closed **Merged:** Yes --- ## Summary - Fix the issue where the thinking timer continues to run after user clicks stop button - The timer now properly stops when `isResponding` is explicitly set to `false` ## Changes - Modified the condition to check for `isResponding === false` instead of `!isResponding` - This distinguishes between explicit stop (`false`) and undefined context (when component is used outside `ChatContextProvider`) - Added comprehensive tests for the `ThinkBlock` component ## Test plan - [x] New unit tests for ThinkBlock component pass - [x] Type check passes (`pnpm type-check:tsgo`) - [x] Lint check passes (`pnpm lint:fix`) fixes #20679
yindo added the pull-request label 2026-02-21 20:52:08 -05:00
yindo closed this issue 2026-02-21 20:52:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32817
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?