langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30444] chore: integrate @tanstack/eslint-plugin-query and fix service layer lint errors #32821

New Issue
Closed
opened 2026-02-21 20:52:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:08 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30444

State: closed
Merged: Yes

Summary

This PR integrates @tanstack/eslint-plugin-query to improve code quality and reliability by enforcing React Query best practices. It also resolves multiple exhaustive-deps violations identified in the service/ directory.

Changes

  • Dependency: Added @tanstack/eslint-plugin-query as a dev dependency.
  • Configuration: Updated eslint.config.mjs to enable the flat/recommended rule set.
  • Refactoring: Fixed missing dependencies in queryKey across multiple service hooks to ensure data freshness and correct caching behavior.

Fix Details

Fixed exhaustive-deps errors in the following files by ensuring all external variables used in queryFn are included in the queryKey:

  • service/use-apps.ts
  • service/use-explore.ts
  • service/use-models.ts
  • service/use-pipeline.ts
  • service/use-plugins.ts
  • service/knowledge/use-segment.ts
  • service/access-control.ts
  • service/knowledge/use-document.ts
  • app/components/goto-anything/index.tsx

Related Issue

Closes #30443

**Original Pull Request:** https://github.com/langgenius/dify/pull/30444 **State:** closed **Merged:** Yes --- ## Summary This PR integrates `@tanstack/eslint-plugin-query` to improve code quality and reliability by enforcing React Query best practices. It also resolves multiple `exhaustive-deps` violations identified in the `service/` directory. ## Changes - **Dependency**: Added `@tanstack/eslint-plugin-query` as a dev dependency. - **Configuration**: Updated `eslint.config.mjs` to enable the `flat/recommended` rule set. - **Refactoring**: Fixed missing dependencies in `queryKey` across multiple service hooks to ensure data freshness and correct caching behavior. ## Fix Details Fixed `exhaustive-deps` errors in the following files by ensuring all external variables used in `queryFn` are included in the `queryKey`: - `service/use-apps.ts` - `service/use-explore.ts` - `service/use-models.ts` - `service/use-pipeline.ts` - `service/use-plugins.ts` - `service/knowledge/use-segment.ts` - `service/access-control.ts` - `service/knowledge/use-document.ts` - `app/components/goto-anything/index.tsx` ## Related Issue Closes #30443
yindo added the pull-request label 2026-02-21 20:52:08 -05:00
yindo closed this issue 2026-02-21 20:52:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32821
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?