langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30491] chore(web): add ESLint rules for i18n JSON validation #32843

New Issue
Closed
opened 2026-02-21 20:52:11 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:11 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30491

State: closed
Merged: Yes

Summary

  • Add valid-i18n-keys rule to ensure i18n JSON keys are flat and don't conflict (no key can be a prefix of another key)
  • Add no-extra-keys rule to ensure non-English JSON files don't have keys missing from en-US (with autofix support)
  • Add utility function to handle JSON files with trailing commas

Test plan

  • Run pnpm lint to verify rules work correctly
  • Verify rules catch invalid key structures in JSON files
  • Verify autofix removes extra keys from non-English translations

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/langgenius/dify/pull/30491 **State:** closed **Merged:** Yes --- ## Summary - Add `valid-i18n-keys` rule to ensure i18n JSON keys are flat and don't conflict (no key can be a prefix of another key) - Add `no-extra-keys` rule to ensure non-English JSON files don't have keys missing from en-US (with autofix support) - Add utility function to handle JSON files with trailing commas ## Test plan - [ ] Run `pnpm lint` to verify rules work correctly - [ ] Verify rules catch invalid key structures in JSON files - [ ] Verify autofix removes extra keys from non-English translations 🤖 Generated with [Claude Code](https://claude.com/claude-code)
yindo added the pull-request label 2026-02-21 20:52:11 -05:00
yindo closed this issue 2026-02-21 20:52:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32843
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?