langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30660] fix: add DB_TYPE environment variable to unit tests #32914

New Issue
Closed
opened 2026-02-21 20:52:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30660

State: closed
Merged: Yes

Summary

Add monkeypatch.setenv("DB_TYPE", "postgresql") to all test functions in test_dify_config.py that set DB_* environment variables.

Changes

  • Added DB_TYPE to test_dify_config
  • Added DB_TYPE to test_http_timeout_defaults
  • Added DB_TYPE to test_flask_configs
  • Added DB_TYPE to test_inner_api_config_exist
  • Added DB_TYPE to test_db_extras_options_merging
  • Added DB_TYPE to test_celery_broker_url_with_special_chars_password

Why

The DB_TYPE configuration variable was recently added to DatabaseConfig, but the unit tests were not updated to include this environment variable. This ensures tests properly set the required configuration.

Closes #30543

**Original Pull Request:** https://github.com/langgenius/dify/pull/30660 **State:** closed **Merged:** Yes --- ## Summary Add `monkeypatch.setenv("DB_TYPE", "postgresql")` to all test functions in `test_dify_config.py` that set DB_* environment variables. ## Changes - Added DB_TYPE to `test_dify_config` - Added DB_TYPE to `test_http_timeout_defaults` - Added DB_TYPE to `test_flask_configs` - Added DB_TYPE to `test_inner_api_config_exist` - Added DB_TYPE to `test_db_extras_options_merging` - Added DB_TYPE to `test_celery_broker_url_with_special_chars_password` ## Why The `DB_TYPE` configuration variable was recently added to `DatabaseConfig`, but the unit tests were not updated to include this environment variable. This ensures tests properly set the required configuration. Closes #30543
yindo added the pull-request label 2026-02-21 20:52:19 -05:00
yindo closed this issue 2026-02-21 20:52:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?