langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 19:50:06 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30666] refactor: remove unnecessary type: ignore from rag_pipeline_fields.py #32919

New Issue
Closed
opened 2026-02-21 20:52:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30666

State: closed
Merged: Yes

Summary

Remove the unnecessary # type: ignore comment from the flask_restx import in api/fields/rag_pipeline_fields.py.

Why

  • The # type: ignore comment on this import is unnecessary
  • Other files in the codebase import from flask_restx without type: ignore comments (e.g., fields/data_source_fields.py, fields/api_based_extension_fields.py, libs/helper.py)
  • Type check passes without this comment

Test plan

  • make type-check passes (0 errors)
  • make lint passes
  • All unit tests pass (4820 passed)

Part of #24494

**Original Pull Request:** https://github.com/langgenius/dify/pull/30666 **State:** closed **Merged:** Yes --- ## Summary Remove the unnecessary `# type: ignore` comment from the flask_restx import in `api/fields/rag_pipeline_fields.py`. ## Why - The `# type: ignore` comment on this import is unnecessary - Other files in the codebase import from `flask_restx` without type: ignore comments (e.g., `fields/data_source_fields.py`, `fields/api_based_extension_fields.py`, `libs/helper.py`) - Type check passes without this comment ## Test plan - [x] `make type-check` passes (0 errors) - [x] `make lint` passes - [x] All unit tests pass (4820 passed) Part of #24494
yindo added the pull-request label 2026-02-21 20:52:19 -05:00
yindo closed this issue 2026-02-21 20:52:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32919
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?