langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30675] fix: signin page stuck on loading when refresh token valid but access token expired #32921

New Issue
Closed
opened 2026-02-21 20:52:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30675

State: closed
Merged: Yes

Summary

  • Fix signin page getting stuck on loading when user has valid refresh token but expired access token
  • Remove loginData?.logged_in from isLoading condition and use explicit isRedirecting state
  • Fix error handling in useIsLogin hook to treat any error as "not logged in"

Test plan

  • Verify signin page loads correctly when not logged in
  • Verify redirect works when user is already logged in
  • Verify page doesn't get stuck when access token expires but refresh token is valid
  • Verify error states (500, network errors) don't cause infinite loading

Fixes #30674

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/langgenius/dify/pull/30675 **State:** closed **Merged:** Yes --- ## Summary - Fix signin page getting stuck on loading when user has valid refresh token but expired access token - Remove `loginData?.logged_in` from `isLoading` condition and use explicit `isRedirecting` state - Fix error handling in `useIsLogin` hook to treat any error as "not logged in" ## Test plan - [ ] Verify signin page loads correctly when not logged in - [ ] Verify redirect works when user is already logged in - [ ] Verify page doesn't get stuck when access token expires but refresh token is valid - [ ] Verify error states (500, network errors) don't cause infinite loading Fixes #30674 🤖 Generated with [Claude Code](https://claude.com/claude-code)
yindo added the pull-request label 2026-02-21 20:52:19 -05:00
yindo closed this issue 2026-02-21 20:52:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32921
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?