langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-08-24 22:11:36 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #30861] fix: dynamically set created_by_role and created_by in BaseAgentRunner #32989

New Issue
Open
opened 2026-02-21 20:52:27 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:27 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/30861

State: open
Merged: No

fix: dynamically set created_by_role and created_by in BaseAgentRunner based on message source

fix #30860

Description

Fixes a bug where created_by_role and created_by were hardcoded in BaseAgentRunner.create_agent_thought(), causing all agent thought records to be incorrectly attributed to account users even when messages originated from end users.

Problem

The create_agent_thought() method in BaseAgentRunner was hardcoding:

  • created_by_role = CreatorUserRole.ACCOUNT
  • created_by = self.user_id

This meant that all MessageAgentThought records were incorrectly marked as account-created, regardless of whether the message came from an end user or account user.

Solution

  • Added _get_creator_info() helper method that inspects self.message to determine the correct creator information
  • Updated create_agent_thought() to use dynamic creator information instead of hardcoded values
  • Logic flow:
    1. If self.message.from_end_user_id is present → set created_by_role to END_USER and created_by to from_end_user_id
    2. Else if self.message.from_account_id is present → set created_by_role to ACCOUNT and created_by to from_account_id
    3. Otherwise → fall back to ACCOUNT role and self.user_id
**Original Pull Request:** https://github.com/langgenius/dify/pull/30861 **State:** open **Merged:** No --- fix: dynamically set created_by_role and created_by in BaseAgentRunner based on message source fix #30860 ### Description Fixes a bug where `created_by_role` and `created_by` were hardcoded in `BaseAgentRunner.create_agent_thought()`, causing all agent thought records to be incorrectly attributed to account users even when messages originated from end users. ### Problem The `create_agent_thought()` method in `BaseAgentRunner` was hardcoding: - `created_by_role = CreatorUserRole.ACCOUNT` - `created_by = self.user_id` This meant that all `MessageAgentThought` records were incorrectly marked as account-created, regardless of whether the message came from an end user or account user. ### Solution - Added `_get_creator_info()` helper method that inspects `self.message` to determine the correct creator information - Updated `create_agent_thought()` to use dynamic creator information instead of hardcoded values - Logic flow: 1. If `self.message.from_end_user_id` is present → set `created_by_role` to `END_USER` and `created_by` to `from_end_user_id` 2. Else if `self.message.from_account_id` is present → set `created_by_role` to `ACCOUNT` and `created_by` to `from_account_id` 3. Otherwise → fall back to `ACCOUNT` role and `self.user_id`
yindo added the pull-request label 2026-02-21 20:52:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#32989
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?