langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31000] fix: increase name length limit in ExternalDatasetCreatePayload #33051

New Issue
Closed
opened 2026-02-21 20:52:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31000

State: closed
Merged: Yes

Description

ExternalDatasetCreatePayload.name have be wrongly set to max_length=40

Copilot Summary

This pull request updates the validation rules for the name field in the ExternalDatasetCreatePayload schema and adds unit tests to ensure these rules are enforced. The main change increases the maximum allowed length of the name field from 40 to 100 characters, and new tests verify both acceptance and rejection at the boundary.

Validation rule update:

  • Increased the maximum length of the name field in ExternalDatasetCreatePayload from 40 to 100 characters to allow longer dataset names.

Testing improvements:

  • Added unit tests in test_external_dataset_payload.py to confirm that the name field accepts up to 100 characters and rejects values longer than 100 characters, ensuring the new validation rule is properly enforced.
  • Added a test module docstring to __init__.py for clarity and documentation of the unit tests.
**Original Pull Request:** https://github.com/langgenius/dify/pull/31000 **State:** closed **Merged:** Yes --- ## Description ExternalDatasetCreatePayload.name have be wrongly set to max_length=40 ## Copilot Summary This pull request updates the validation rules for the `name` field in the `ExternalDatasetCreatePayload` schema and adds unit tests to ensure these rules are enforced. The main change increases the maximum allowed length of the `name` field from 40 to 100 characters, and new tests verify both acceptance and rejection at the boundary. Validation rule update: * Increased the maximum length of the `name` field in `ExternalDatasetCreatePayload` from 40 to 100 characters to allow longer dataset names. Testing improvements: * Added unit tests in `test_external_dataset_payload.py` to confirm that the `name` field accepts up to 100 characters and rejects values longer than 100 characters, ensuring the new validation rule is properly enforced. * Added a test module docstring to `__init__.py` for clarity and documentation of the unit tests.
yindo added the pull-request label 2026-02-21 20:52:34 -05:00
yindo closed this issue 2026-02-21 20:52:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33051
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?