langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 13:05:55 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31075] fix: use configured max_retries in HTTP Request node error message #33081

New Issue
Open
opened 2026-02-21 20:52:37 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:37 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31075

State: open
Merged: No

Summary

Fixes #31071 - The error message for HTTP Request node retries was showing incorrect retry count

Problem

When the HTTP Request node's retry feature was enabled, the error message always showed "0 retries" because the Executor was initialized with a hardcoded max_retries=0 instead of the configured value.

Solution

Modified _run method to use the configured max_retries from retry_config when retry is enabled.

Changes

  • Modified api/core/workflow/nodes/http_request/node.py:
    • Read max_retries from retry_config when retry is enabled
    • Pass the correct value to Executor

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=146701565

**Original Pull Request:** https://github.com/langgenius/dify/pull/31075 **State:** open **Merged:** No --- ## Summary Fixes #31071 - The error message for HTTP Request node retries was showing incorrect retry count ## Problem When the HTTP Request node's retry feature was enabled, the error message always showed "0 retries" because the `Executor` was initialized with a hardcoded `max_retries=0` instead of the configured value. ## Solution Modified `_run` method to use the configured `max_retries` from `retry_config` when retry is enabled. ## Changes - Modified `api/core/workflow/nodes/http_request/node.py`: - Read `max_retries` from `retry_config` when retry is enabled - Pass the correct value to `Executor` Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=146701565
yindo added the pull-request label 2026-02-21 20:52:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33081
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?