langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31157] chore: introduce bulk-suppressions and multithread linting #33114

New Issue
Closed
opened 2026-02-21 20:52:41 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:41 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31157

State: closed
Merged: Yes

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

close #31153

close #31154

In CI

--concurrency off 4m 12s
--concurrency 2 2m 38s
--concurrency 3 2m 36s
--concurrency 3 2m 39s

On my MacBook Pro 14 M1 Pro 16g

hyperfine --parameter-list concurrency off,2,3,4 "node node_modules/eslint/bin/eslint --quiet --concurrency {concurrency}"

Benchmark 1: node node_modules/eslint/bin/eslint --quiet --concurrency off
  Time (mean ± σ):     138.477 s ±  2.096 s    [User: 167.845 s, System: 4.455 s]
  Range (min … max):   133.202 s … 140.692 s    10 runs
 
Benchmark 2: node node_modules/eslint/bin/eslint --quiet --concurrency 2
  Time (mean ± σ):     86.875 s ±  4.023 s    [User: 211.254 s, System: 7.575 s]
  Range (min … max):   79.709 s … 91.538 s    10 runs
 
Benchmark 3: node node_modules/eslint/bin/eslint --quiet --concurrency 3
  Time (mean ± σ):     67.782 s ±  2.226 s    [User: 237.377 s, System: 12.081 s]
  Range (min … max):   64.444 s … 70.978 s    10 runs
 
Benchmark 4: node node_modules/eslint/bin/eslint --quiet --concurrency 4
  Time (mean ± σ):     58.924 s ±  2.706 s    [User: 262.392 s, System: 17.188 s]
  Range (min … max):   53.956 s … 63.378 s    10 runs
 
Summary
  node node_modules/eslint/bin/eslint --quiet --concurrency 4 ran
    1.15 ± 0.06 times faster than node node_modules/eslint/bin/eslint --quiet --concurrency 3
    1.47 ± 0.10 times faster than node node_modules/eslint/bin/eslint --quiet --concurrency 2
    2.35 ± 0.11 times faster than node node_modules/eslint/bin/eslint --quiet --concurrency off

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/31157 **State:** closed **Merged:** Yes --- > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. ## Summary <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> close #31153 close #31154 In CI ``` --concurrency off 4m 12s --concurrency 2 2m 38s --concurrency 3 2m 36s --concurrency 3 2m 39s ``` On my MacBook Pro 14 M1 Pro 16g `hyperfine --parameter-list concurrency off,2,3,4 "node node_modules/eslint/bin/eslint --quiet --concurrency {concurrency}"` ``` Benchmark 1: node node_modules/eslint/bin/eslint --quiet --concurrency off Time (mean ± σ): 138.477 s ± 2.096 s [User: 167.845 s, System: 4.455 s] Range (min … max): 133.202 s … 140.692 s 10 runs Benchmark 2: node node_modules/eslint/bin/eslint --quiet --concurrency 2 Time (mean ± σ): 86.875 s ± 4.023 s [User: 211.254 s, System: 7.575 s] Range (min … max): 79.709 s … 91.538 s 10 runs Benchmark 3: node node_modules/eslint/bin/eslint --quiet --concurrency 3 Time (mean ± σ): 67.782 s ± 2.226 s [User: 237.377 s, System: 12.081 s] Range (min … max): 64.444 s … 70.978 s 10 runs Benchmark 4: node node_modules/eslint/bin/eslint --quiet --concurrency 4 Time (mean ± σ): 58.924 s ± 2.706 s [User: 262.392 s, System: 17.188 s] Range (min … max): 53.956 s … 63.378 s 10 runs Summary node node_modules/eslint/bin/eslint --quiet --concurrency 4 ran 1.15 ± 0.06 times faster than node node_modules/eslint/bin/eslint --quiet --concurrency 3 1.47 ± 0.10 times faster than node node_modules/eslint/bin/eslint --quiet --concurrency 2 2.35 ± 0.11 times faster than node node_modules/eslint/bin/eslint --quiet --concurrency off ``` ## Screenshots | Before | After | |--------|-------| | ... | ... | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:52:41 -05:00
yindo closed this issue 2026-02-21 20:52:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?