langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-23 04:55:28 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31276] fix: add list type support for ToolInput constant value in tool node #33160

New Issue
Closed
opened 2026-02-21 20:52:46 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:46 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31276

State: closed
Merged: Yes

  • Add list type validation for checkbox multi-select parameters
  • Align ToolInput validation with TriggerEventInput behavior
  • Fix ValidationError when using checkbox type tool parameters

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Fixes https://github.com/langgenius/dify/issues/31282

Summary

This PR fixes a validation error when using checkbox (multi-select) type parameters in tool nodes.

Problem

When a tool node has a checkbox parameter, executing the workflow fails with:

ValidationError: 1 validation error for ToolInput type Value error, value must be a string, int, float, bool or dict

Root Cause

Checkbox multi-select controls store values as arrays (e.g., ['female']), but the ToolInput validator in tool nodes did not support list type, while TriggerEventInput in trigger nodes already does.

Comparison:

Node Type Supported value types
Trigger Node (TriggerEventInput) str, int, float, bool, dict, list ✅
Tool Node (ToolInput) str, int, float, bool, dict ❌

Solution

Add list type support to ToolInput.check_type() validator to align with TriggerEventInput behavior.

Changes

  • api/core/workflow/nodes/tool/entities.py: Add list type validation for constant value in ToolInput

Screenshots

Before After
image image
ValidationError when using checkbox parameters in tool node Tool node executes successfully with checkbox parameters

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/31276 **State:** closed **Merged:** Yes --- - Add list type validation for checkbox multi-select parameters - Align ToolInput validation with TriggerEventInput behavior - Fix ValidationError when using checkbox type tool parameters > [!IMPORTANT] > > 1. Make sure you have read our [contribution guidelines](https://github.com/langgenius/dify/blob/main/CONTRIBUTING.md) > 1. Ensure there is an associated issue and you have been assigned to it > 1. Use the correct syntax to link this PR: `Fixes #<issue number>`. Fixes https://github.com/langgenius/dify/issues/31282 ## Summary This PR fixes a validation error when using checkbox (multi-select) type parameters in tool nodes. ### Problem When a tool node has a checkbox parameter, executing the workflow fails with: ``` ValidationError: 1 validation error for ToolInput type Value error, value must be a string, int, float, bool or dict ``` ### Root Cause Checkbox multi-select controls store values as arrays (e.g., `['female']`), but the `ToolInput` validator in tool nodes did not support `list` type, while `TriggerEventInput` in trigger nodes already does. **Comparison:** | Node Type | Supported value types | |-----------|----------------------| | Trigger Node (`TriggerEventInput`) | `str`, `int`, `float`, `bool`, `dict`, `list` ✅ | | Tool Node (`ToolInput`) | `str`, `int`, `float`, `bool`, `dict` ❌ | ### Solution Add `list` type support to `ToolInput.check_type()` validator to align with `TriggerEventInput` behavior. ### Changes - `api/core/workflow/nodes/tool/entities.py`: Add `list` type validation for constant value in `ToolInput` ## Screenshots | Before | After | |--------|-------| |<img width="632" height="310" alt="image" src="https://github.com/user-attachments/assets/8f1186ba-07ee-49bc-86e1-a2c126d5121f" />|<img width="1576" height="688" alt="image" src="https://github.com/user-attachments/assets/6e07ad1b-4d45-491f-a7b2-9cd88b5f5a14" /> | | ValidationError when using checkbox parameters in tool node | Tool node executes successfully with checkbox parameters | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:52:46 -05:00
yindo closed this issue 2026-02-21 20:52:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33160
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?