langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31277] fix(workflow): prevent Start node from being deleted #33163

New Issue
Closed
opened 2026-02-21 20:52:46 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:46 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31277

State: closed
Merged: No

Summary

This PR fixes a bug where the Start node could be accidentally deleted in Workflow mode by pressing the Delete key, breaking the entire workflow with no way to recover.

Fixes: #31275

Problem

  • Users could select the Start node and press Delete to remove it
  • Once deleted, the Start node could not be added back
  • Ctrl+Z (undo) didn't restore it
  • The workflow becomes completely broken

Root Cause

In use-available-nodes-meta-data.ts, the Start node was only marked as undeletable in Chat mode:

isUndeletable: isChatMode, // start node is undeletable in chat mode

This meant in regular Workflow mode (isChatMode = false), the Start node could be deleted.

Solution

Changed to always protect the Start node:

isUndeletable: true, // start node is always undeletable - it's the workflow entry point

The Start node is the essential entry point for all workflows and should never be deletable.

Testing

  1. Create a new Workflow
  2. Select the Start node
  3. Press Delete key
  4. ✅ Start node is NOT deleted

[Gittensor contribution - GlobalStar117]

**Original Pull Request:** https://github.com/langgenius/dify/pull/31277 **State:** closed **Merged:** No --- ## Summary This PR fixes a bug where the Start node could be accidentally deleted in Workflow mode by pressing the Delete key, breaking the entire workflow with no way to recover. **Fixes:** #31275 ## Problem - Users could select the Start node and press Delete to remove it - Once deleted, the Start node could not be added back - Ctrl+Z (undo) didn't restore it - The workflow becomes completely broken ## Root Cause In `use-available-nodes-meta-data.ts`, the Start node was only marked as undeletable in **Chat mode**: ```typescript isUndeletable: isChatMode, // start node is undeletable in chat mode ``` This meant in regular Workflow mode (`isChatMode = false`), the Start node could be deleted. ## Solution Changed to always protect the Start node: ```typescript isUndeletable: true, // start node is always undeletable - it's the workflow entry point ``` The Start node is the essential entry point for all workflows and should never be deletable. ## Testing 1. Create a new Workflow 2. Select the Start node 3. Press Delete key 4. ✅ Start node is NOT deleted --- [Gittensor contribution - GlobalStar117]
yindo added the pull-request label 2026-02-21 20:52:46 -05:00
yindo closed this issue 2026-02-21 20:52:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?