langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31381] fix: allow webm/mpeg formats in audio-to-text endpoint #33209

New Issue
Open
opened 2026-02-21 20:52:52 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:52 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31381

State: open
Merged: No

  • Added webm, mpeg, and mp4 to ALLOWED_EXTENSIONS in constants.
  • Updated unit tests to verify support for these formats.

Closes #29726

This PR addresses the issue where the /audio-to-text endpoint was rejecting audio formats (webm, mp4, mpeg) that are listed as supported in the documentation and supported by the underlying OpenAI backend.

Previously, uploading these file types resulted in a 415 Unsupported Audio Type error despite the documentation claiming support.

Fixes

Fixes #29726

Changes

  • Updated Validation: Added webm, mp4, and mpeg to the ALLOWED_EXTENSIONS list in api/constants/__init__.py.
  • Updated Tests: Modified api/tests/unit_tests/core/datasource/test_file_upload.py to verify that these extensions now pass validation.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/31381 **State:** open **Merged:** No --- - Added webm, mpeg, and mp4 to ALLOWED_EXTENSIONS in constants. - Updated unit tests to verify support for these formats. Closes #29726 This PR addresses the issue where the `/audio-to-text` endpoint was rejecting audio formats (`webm`, `mp4`, `mpeg`) that are listed as supported in the documentation and supported by the underlying OpenAI backend. Previously, uploading these file types resulted in a `415 Unsupported Audio Type` error despite the documentation claiming support. ### Fixes Fixes #29726 ### Changes - **Updated Validation:** Added `webm`, `mp4`, and `mpeg` to the `ALLOWED_EXTENSIONS` list in `api/constants/__init__.py`. - **Updated Tests:** Modified `api/tests/unit_tests/core/datasource/test_file_upload.py` to verify that these extensions now pass validation. ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [ ] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:52:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33209
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?