langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31458] fix: replace Any type annotation with dict[str, Any] | None for retrieval_model parameter #33244

New Issue
Open
opened 2026-02-21 20:52:56 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:52:56 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31458

State: open
Merged: No

Description

This PR addresses the FIXME comment in hit_testing_service.py by replacing the Any type annotation with a more specific type annotation dict[str, Any] | None for the retrieval_model parameter.

Changes

  • Replaced Any type with dict[str, Any] | None for retrieval_model parameter in HitTestingService.retrieve() method
  • Improves type safety and code clarity
  • The parameter is used as a dictionary throughout the method, so this type annotation accurately reflects its usage

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Code quality improvement

Testing

  • No functional changes, only type annotation improvement
  • Existing tests should continue to pass
**Original Pull Request:** https://github.com/langgenius/dify/pull/31458 **State:** open **Merged:** No --- ## Description This PR addresses the FIXME comment in `hit_testing_service.py` by replacing the `Any` type annotation with a more specific type annotation `dict[str, Any] | None` for the `retrieval_model` parameter. ## Changes - Replaced `Any` type with `dict[str, Any] | None` for `retrieval_model` parameter in `HitTestingService.retrieve()` method - Improves type safety and code clarity - The parameter is used as a dictionary throughout the method, so this type annotation accurately reflects its usage ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [x] Code quality improvement ## Testing - No functional changes, only type annotation improvement - Existing tests should continue to pass
yindo added the pull-request label 2026-02-21 20:52:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33244
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?