langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 20:15:31 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31558] fix: wrap test cleanup in act() to prevent window is not defined error #33292

New Issue
Closed
opened 2026-02-21 20:53:01 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:01 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31558

State: closed
Merged: Yes

Summary

Fixes #31326

React 19's scheduler uses setImmediate/MessageChannel to schedule work, which can fire after jsdom cleanup causing random "window is not defined" errors in tests. This PR wraps the test cleanup in act() to ensure all pending React scheduler work is flushed before the test environment is torn down.

The error was occurring at react-dom-client.development.js:17920 where React tries to access window.event in a scheduled callback that fires after jsdom has been cleaned up.

Screenshots

Before After
Random test failures with "window is not defined" Tests pass consistently

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods
**Original Pull Request:** https://github.com/langgenius/dify/pull/31558 **State:** closed **Merged:** Yes --- ## Summary Fixes #31326 React 19's scheduler uses `setImmediate`/`MessageChannel` to schedule work, which can fire after jsdom cleanup causing random "window is not defined" errors in tests. This PR wraps the test cleanup in `act()` to ensure all pending React scheduler work is flushed before the test environment is torn down. The error was occurring at `react-dom-client.development.js:17920` where React tries to access `window.event` in a scheduled callback that fires after jsdom has been cleaned up. ## Screenshots | Before | After | |--------|-------| | Random test failures with "window is not defined" | Tests pass consistently | ## Checklist - [ ] This change requires a documentation update, included: [Dify Document](https://github.com/langgenius/dify-docs) - [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!) - [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. - [x] I've updated the documentation accordingly. - [x] I ran `make lint` and `make type-check` (backend) and `cd web && npx lint-staged` (frontend) to appease the lint gods
yindo added the pull-request label 2026-02-21 20:53:01 -05:00
yindo closed this issue 2026-02-21 20:53:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33292
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?