langgenius/dify
1
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-21 12:05:30 -04:00
Code Issues 775 Packages Projects Releases 10 Wiki Activity

[PR #31697] fix: use query params instead of request body for decode_plugin_from_identifier #33355

New Issue
Open
opened 2026-02-21 20:53:08 -05:00 by yindo · 0 comments
yindo commented 2026-02-21 20:53:08 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/langgenius/dify/pull/31697

State: open
Merged: No

Summary

  • Changed decode_plugin_from_identifier to use query parameters (params=) instead of request body (data=)
  • Removed unnecessary Content-Type: application/json header

Problem

The decode_plugin_from_identifier endpoint was sending plugin_unique_identifier in the request body with a GET request. This causes issues with HTTP intermediaries like Google Cloud Run's frontend, which rejects GET requests with a body as malformed (returning 400 Bad Request before the request reaches the container).

Solution

Changed from data= (request body) to params= (query parameters), which is:

  • Consistent with similar GET endpoints (fetch_plugin_manifest, fetch_plugin_by_identifier)
  • Compliant with HTTP standards
  • Compatible with Cloud Run and other HTTP proxies/load balancers

Related PR

This change requires a corresponding change in dify-plugin-daemon to accept the parameter from query string instead of JSON body:

**Original Pull Request:** https://github.com/langgenius/dify/pull/31697 **State:** open **Merged:** No --- ## Summary - Changed `decode_plugin_from_identifier` to use query parameters (`params=`) instead of request body (`data=`) - Removed unnecessary `Content-Type: application/json` header ## Problem The `decode_plugin_from_identifier` endpoint was sending `plugin_unique_identifier` in the request body with a GET request. This causes issues with HTTP intermediaries like **Google Cloud Run's frontend**, which rejects GET requests with a body as malformed (returning 400 Bad Request before the request reaches the container). ## Solution Changed from `data=` (request body) to `params=` (query parameters), which is: - Consistent with similar GET endpoints (`fetch_plugin_manifest`, `fetch_plugin_by_identifier`) - Compliant with HTTP standards - Compatible with Cloud Run and other HTTP proxies/load balancers ## Related PR This change requires a corresponding change in dify-plugin-daemon to accept the parameter from query string instead of JSON body: - https://github.com/langgenius/dify-plugin-daemon/pull/593
yindo added the pull-request label 2026-02-21 20:53:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Knowledge Pipeline
Proposal
WIP
cloud
dependencies
feat:webapp
good first issue
outdated
performance
pull-request
Mirrored from GitHub Pull Request
 python:uv
refactor
size:L
stale
status: accepting prs
status: blocked
status: in discussion
stt & tts
vulnerablity
web
wont-fix
🌊 feat:workflow
🌚 invalid
🐞 bug
👻 feat:rag
💪 enhancement
📚 documentation
🔨 feat:tools
🙋‍♂️ question
🙏 help wanted
🤔 cant-reproduce
🤖 feat:agent
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: langgenius/dify#33355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?